test(sync): Improve test_sync_rotate to prevent false positives#816
Merged
test(sync): Improve test_sync_rotate to prevent false positives#816
Conversation
glevco
previously approved these changes
Oct 18, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 84.65% 84.60% -0.06%
==========================================
Files 266 266
Lines 22123 22131 +8
Branches 3379 3380 +1
==========================================
- Hits 18728 18723 -5
- Misses 2734 2745 +11
- Partials 661 663 +2
☔ View full report in Codecov by Sentry. |
jansegre
previously approved these changes
Oct 18, 2023
96167d7 to
6b039c1
Compare
Base automatically changed from
test/fix-flaky-test_many_miners_since_beginning
to
master
October 18, 2023 15:36
The base branch was changed.
a9b2a4c to
3c9bac8
Compare
glevco
approved these changes
Oct 18, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The
test_sync_rotate()had an assert with 0.0877% change of failing. As every CI job executes it 6 times, it had a change of 0.52% of failing, i.e., 1 out of 200 CI executions.Acceptance Criteria
test_sync_rotate()to reduce the chance of failing to 0.000483%, which reduces the chance of a CI failing from 0.52% to 0.00289797% (1 out of 35,000 CI executions).Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged