Conversation
4a0cd00 to
925fe90
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 84.73% 84.74% +0.01%
==========================================
Files 259 259
Lines 21912 21912
Branches 2963 2963
==========================================
+ Hits 18567 18570 +3
+ Misses 2698 2696 -2
+ Partials 647 646 -1 ☔ View full report in Codecov by Sentry. |
925fe90 to
2fdc1d0
Compare
jansegre
left a comment
There was a problem hiding this comment.
All tests are failing, is this ready for review?
@jansegre yes, it's just my bad luck. Only one passed, actually, 3.11 on Windows. I'll rerun them anyway |
@jansegre I don't think so, I've looked at the failures and it looks like they're all either from the |
2fdc1d0 to
a847f51
Compare
Motivation
PR #753 introduced the new
pause_after_exactly()miner simulator ability, and changed Feature Activation mining simulation tests to use it instead of theStopAfterNMinedBlocks, removing flakiness. Since the trigger was removed, the test running times were unnecessarily too long.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged