chore: improve miner simulator flakiness#753
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
==========================================
+ Coverage 84.62% 84.67% +0.04%
==========================================
Files 253 252 -1
Lines 21708 21770 +62
Branches 2941 2946 +5
==========================================
+ Hits 18371 18434 +63
+ Misses 2702 2692 -10
- Partials 635 644 +9
|
jansegre
previously approved these changes
Aug 23, 2023
c3361c8 to
f89cd71
Compare
6ee97e8 to
4b68c2c
Compare
msbrogli
previously approved these changes
Aug 23, 2023
Base automatically changed from
feat/feature-activation/bit-signal-templates
to
master
August 23, 2023 20:40
The base branch was changed.
4b68c2c to
bd5311f
Compare
jansegre
approved these changes
Aug 24, 2023
This was referenced Aug 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Due to the expected behavior of the
StopAfterNMinedBlockstrigger, which is to stop the simulation after finding "at least N blocks", some tests were flaky. A new mechanism is introduced directly on the miner simulator to guarantee it stops producing blocks after exactly N blocks are found.This new mechanism is used specifically in Feature Activation mining simulation tests, but any other tests that are found to be flaky because of this behavior, could be migrated to this alternative.
Acceptance Criteria
pause_after_exactly()method for miner simulatorsChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged