Conversation
1 task
msbrogli
previously approved these changes
Aug 2, 2023
jansegre
previously approved these changes
Aug 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 84.43% 84.55% +0.11%
==========================================
Files 251 252 +1
Lines 21607 21688 +81
Branches 2923 2937 +14
==========================================
+ Hits 18244 18338 +94
+ Misses 2724 2712 -12
+ Partials 639 638 -1
|
jansegre
approved these changes
Aug 2, 2023
msbrogli
approved these changes
Aug 2, 2023
0d44bb5 to
4e97384
Compare
1 task
This was referenced Aug 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, trying to access Feature Activation endpoints on our public nodes returns 403 Forbidden, like on https://node1.mainnet.hathor.network/v1a/feature. This PR updates the endpoint visibility so it can be used by the Hathor Explorer UIs.
Acceptance Criteria
GET /featurevisibility to public and add rate limits (the same used byGET /transaction)Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged