Skip to content

chore(event-queue): update event endpoints visibility to public#746

Merged
msbrogli merged 1 commit intomasterfrom
chore/event-queue/endpoint-visibility
Aug 3, 2023
Merged

chore(event-queue): update event endpoints visibility to public#746
msbrogli merged 1 commit intomasterfrom
chore/event-queue/endpoint-visibility

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Aug 3, 2023

Motivation

Currently, trying to access Event Queue endpoints on our public nodes returns 403 Forbidden. This PR updates the endpoints visibility so they can be used by clients.

Acceptance Criteria

  • Change GET /event visibility to public and add rate limits (the same used by GET /feature)
  • Add /event_ws websocket endpoint to nginx config, using the same parameters as /mining_ws

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Aug 3, 2023
@glevco glevco changed the base branch from master to chore/feature-activation/endpoint-visibility August 3, 2023 16:20
@glevco glevco changed the title Chore/event queue/endpoint visibility chore(event-queue): update event endpoints visibility to public Aug 3, 2023
@glevco glevco marked this pull request as ready for review August 3, 2023 16:24
jansegre
jansegre previously approved these changes Aug 3, 2023
msbrogli
msbrogli previously approved these changes Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #746 (c95834d) into master (48a64d6) will increase coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   84.54%   84.56%   +0.01%     
==========================================
  Files         252      252              
  Lines       21688    21688              
  Branches     2937     2937              
==========================================
+ Hits        18337    18341       +4     
+ Misses       2712     2709       -3     
+ Partials      639      638       -1     
Files Changed Coverage Δ
hathor/event/resources/event.py 86.84% <ø> (ø)
hathor/feature_activation/resources/feature.py 94.04% <ø> (ø)

... and 2 files with indirect coverage changes

Base automatically changed from chore/feature-activation/endpoint-visibility to master August 3, 2023 17:32
@jansegre jansegre dismissed stale reviews from msbrogli and themself August 3, 2023 17:32

The base branch was changed.

@glevco glevco force-pushed the chore/event-queue/endpoint-visibility branch from fd9d40f to c95834d Compare August 3, 2023 17:34
@msbrogli msbrogli merged commit c95834d into master Aug 3, 2023
@msbrogli msbrogli deleted the chore/event-queue/endpoint-visibility branch August 3, 2023 19:58
This was referenced Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants