chore(event-queue): update event endpoints visibility to public#746
Merged
chore(event-queue): update event endpoints visibility to public#746
Conversation
jansegre
previously approved these changes
Aug 3, 2023
msbrogli
previously approved these changes
Aug 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 84.54% 84.56% +0.01%
==========================================
Files 252 252
Lines 21688 21688
Branches 2937 2937
==========================================
+ Hits 18337 18341 +4
+ Misses 2712 2709 -3
+ Partials 639 638 -1
|
Base automatically changed from
chore/feature-activation/endpoint-visibility
to
master
August 3, 2023 17:32
The base branch was changed.
fd9d40f to
c95834d
Compare
msbrogli
approved these changes
Aug 3, 2023
jansegre
approved these changes
Aug 3, 2023
This was referenced Aug 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, trying to access Event Queue endpoints on our public nodes returns 403 Forbidden. This PR updates the endpoints visibility so they can be used by clients.
Acceptance Criteria
GET /eventvisibility to public and add rate limits (the same used byGET /feature)/event_wswebsocket endpoint to nginx config, using the same parameters as/mining_wsChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged