feat(feature-activation): fix criteria validation#708
Merged
Conversation
1 task
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
- Coverage 84.00% 83.99% -0.02%
==========================================
Files 246 246
Lines 20517 20523 +6
Branches 2769 2770 +1
==========================================
+ Hits 17236 17238 +2
- Misses 2707 2709 +2
- Partials 574 576 +2
|
jansegre
previously approved these changes
Jul 18, 2023
msbrogli
requested changes
Jul 18, 2023
4d1be8e to
454ca26
Compare
msbrogli
approved these changes
Jul 19, 2023
jansegre
approved these changes
Jul 19, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Due to the way validations were performed on the
Criteriaclass, some tests were flaky and behaving in unexpected ways. This PR changes the way Criteria attributes are validated to a more robust solution.Acceptance Criteria
ValidatedCriteriaclass and move allCriteriavalidation to itCriteria.to_validated()methodFeatureSettingsvalidation to use the newCriteriavalidation structureChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged