feat(feature-activation): implement bit signaling service#702
Merged
Conversation
6a507b4 to
a2c0210
Compare
a2c0210 to
522ffbd
Compare
1 task
Codecov Report
@@ Coverage Diff @@
## master #702 +/- ##
==========================================
- Coverage 84.00% 83.99% -0.02%
==========================================
Files 246 247 +1
Lines 20517 20589 +72
Branches 2769 2779 +10
==========================================
+ Hits 17236 17294 +58
- Misses 2707 2716 +9
- Partials 574 579 +5
|
jansegre
previously approved these changes
Jul 17, 2023
8c7be67 to
4ab2466
Compare
1 task
jansegre
previously approved these changes
Jul 18, 2023
4d1be8e to
454ca26
Compare
4ab2466 to
1092ff1
Compare
msbrogli
previously approved these changes
Jul 19, 2023
Base automatically changed from
fix/feature-activation/criteria-validation
to
master
July 19, 2023 17:44
The base branch was changed.
0519850 to
9176efb
Compare
jansegre
approved these changes
Jul 19, 2023
msbrogli
approved these changes
Jul 19, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements the
BitSignalingServiceas defined in this RFC.Acceptance Criteria
--signal-supportand--signal-not-supportCLI optionsCriteria.signal_support_by_defaultattributeFeatureState.get_signaling_states()methodBitSignalingServiceChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged