Skip to content

chore(events): move event queue option to unsafe args #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glevco merged 1 commit into from
Jun 12, 2023
Merged

chore(events): move event queue option to unsafe args #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions hathor/builder/cli_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,6 @@ def create_manager(self, reactor: PosixReactorBase, args: Namespace) -> HathorMa
consensus_algorithm = ConsensusAlgorithm(soft_voided_tx_ids, pubsub=pubsub)

if args.x_enable_event_queue:
if not settings.ENABLE_EVENT_QUEUE_FEATURE:
self.log.error('The event queue feature is not available yet')
sys.exit(-1)

self.log.info('--x-enable-event-queue flag provided. '
'The events detected by the full node will be stored and can be retrieved by clients')

Expand Down
1 change: 1 addition & 0 deletions hathor/cli/run_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class RunNode:
('--enable-crash-api', lambda args: bool(args.enable_crash_api)),
('--x-sync-bridge', lambda args: bool(args.x_sync_bridge)),
('--x-sync-v2-only', lambda args: bool(args.x_sync_v2_only)),
('--x-enable-event-queue', lambda args: bool(args.x_enable_event_queue))
]

@classmethod
Expand Down
2 changes: 0 additions & 2 deletions hathor/conf/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,6 @@ def MAXIMUM_NUMBER_OF_HALVINGS(self) -> int:
# Identifier used in metadata's voided_by to mark a tx as partially validated.
PARTIALLY_VALIDATED_ID: bytes = b'pending-validation'

ENABLE_EVENT_QUEUE_FEATURE: bool = False

EVENT_API_DEFAULT_BATCH_SIZE: int = 100

EVENT_API_MAX_BATCH_SIZE: int = 1000
Expand Down
1 change: 0 additions & 1 deletion hathor/conf/unittests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@
GENESIS_TX2_HASH=bytes.fromhex('33e14cb555a96967841dcbe0f95e9eab5810481d01de8f4f73afb8cce365e869'),
REWARD_SPEND_MIN_BLOCKS=10,
SLOW_ASSERTS=True,
ENABLE_EVENT_QUEUE_FEATURE=True,
MAX_TX_WEIGHT_DIFF_ACTIVATION=0.0,
)
1 change: 0 additions & 1 deletion hathor/conf/unittests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ GENESIS_TX2_NONCE: 2
GENESIS_TX2_HASH: 33e14cb555a96967841dcbe0f95e9eab5810481d01de8f4f73afb8cce365e869
REWARD_SPEND_MIN_BLOCKS: 10
SLOW_ASSERTS: true
ENABLE_EVENT_QUEUE_FEATURE: true
MAX_TX_WEIGHT_DIFF_ACTIVATION: 0.0
1 change: 0 additions & 1 deletion tests/others/fixtures/invalid_byte_hathor_settings_fixture.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ BLOCK_DIFFICULTY_N_BLOCKS: 20

REWARD_SPEND_MIN_BLOCKS: 10
SLOW_ASSERTS: true
ENABLE_EVENT_QUEUE_FEATURE: true
MAX_TX_WEIGHT_DIFF_ACTIVATION: 0.0

CHECKPOINTS:
Expand Down
1 change: 0 additions & 1 deletion tests/others/fixtures/invalid_features_hathor_settings_fixture.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ BLOCK_DIFFICULTY_N_BLOCKS: 20

REWARD_SPEND_MIN_BLOCKS: 10
SLOW_ASSERTS: true
ENABLE_EVENT_QUEUE_FEATURE: true
MAX_TX_WEIGHT_DIFF_ACTIVATION: 0.0

CHECKPOINTS:
Expand Down
1 change: 0 additions & 1 deletion tests/others/fixtures/missing_hathor_settings_fixture.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ BLOCK_DIFFICULTY_N_BLOCKS: 20

REWARD_SPEND_MIN_BLOCKS: 10
SLOW_ASSERTS: true
ENABLE_EVENT_QUEUE_FEATURE: true
MAX_TX_WEIGHT_DIFF_ACTIVATION: 0.0

CHECKPOINTS:
Expand Down
1 change: 0 additions & 1 deletion tests/others/fixtures/valid_hathor_settings_fixture.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ BLOCK_DIFFICULTY_N_BLOCKS: 20

REWARD_SPEND_MIN_BLOCKS: 10
SLOW_ASSERTS: true
ENABLE_EVENT_QUEUE_FEATURE: true
MAX_TX_WEIGHT_DIFF_ACTIVATION: 0.0

CHECKPOINTS:
Expand Down
1 change: 0 additions & 1 deletion tests/others/test_hathor_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def test_valid_hathor_settings_from_yaml(filepath):
],
REWARD_SPEND_MIN_BLOCKS=10,
SLOW_ASSERTS=True,
ENABLE_EVENT_QUEUE_FEATURE=True,
MAX_TX_WEIGHT_DIFF_ACTIVATION=0.0,
BLOCKS_PER_HALVING=120,
MIN_BLOCK_WEIGHT=2,
Expand Down