Skip to content

chore(events): move event queue option to unsafe args#656

Merged
glevco merged 1 commit intomasterfrom
chore/enable-event-queue
Jun 12, 2023
Merged

chore(events): move event queue option to unsafe args#656
glevco merged 1 commit intomasterfrom
chore/enable-event-queue

Conversation

@glevco
Copy link
Copy Markdown
Contributor

@glevco glevco commented Jun 7, 2023

Acceptance Criteria

  • Remove ENABLE_EVENT_QUEUE_FEATURE feature flag from HathorSettings and move --x-enable-event-queue CLI option to unsafe args

@glevco glevco self-assigned this Jun 7, 2023
@glevco glevco marked this pull request as ready for review June 7, 2023 23:22
@glevco glevco requested review from jansegre and msbrogli as code owners June 7, 2023 23:22
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 7, 2023

Codecov Report

Merging #656 (bdcc2d6) into master (74a5ac6) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   84.04%   84.06%   +0.01%     
==========================================
  Files         245      245              
  Lines       20279    20275       -4     
  Branches     2757     2756       -1     
==========================================
  Hits        17044    17044              
+ Misses       2637     2635       -2     
+ Partials      598      596       -2     
Impacted Files Coverage Δ
hathor/builder/cli_builder.py 72.67% <ø> (+1.17%) ⬆️
hathor/conf/settings.py 97.03% <ø> (-0.03%) ⬇️
hathor/conf/unittests.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@glevco glevco force-pushed the chore/enable-event-queue branch from c54af97 to bdcc2d6 Compare June 9, 2023 20:22
@glevco glevco merged commit 57489f9 into master Jun 12, 2023
@glevco glevco deleted the chore/enable-event-queue branch June 12, 2023 18:03
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants