Skip to content

chore: Test Improvements #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glevco merged 11 commits into from
Feb 7, 2023
Merged

chore: Test Improvements #521

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fff146d
feat(pydantic-install): install pydantic
glevco Feb 2, 2023
f6671df
feat(pydantic-install): add missing docstrings
glevco Feb 3, 2023
1fa95bc
feat(events): change test utils so filepath is not hardcoded
glevco Feb 4, 2023
3f555df
feat(events): change builder to accept custom settings
glevco Feb 4, 2023
d757f62
feat(events): fix builder typing
glevco Feb 4, 2023
4545545
feat(events): fix builder typing
glevco Feb 4, 2023
38c7472
feat(pydantic-install): fix mypy plugin
glevco Feb 6, 2023
a43c591
Merge branch 'feat/pydantic-install' into chore/test-improvements
glevco Feb 6, 2023
b8c0f9c
Merge branch 'dev' into chore/test-improvements
glevco Feb 7, 2023
9ad7bfe
feat(test-improvements): rollback builder changes
glevco Feb 7, 2023
a5b432e
feat(test-improvements): move filepath code into function
glevco Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tests/unittest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,26 @@ def shorten_hash(container):
return container_type(h[-2:].hex() for h in container)


def _load_peer_id_pool(file_path: str = 'tests/peer_id_pool.json') -> Iterator[PeerId]:
def _load_peer_id_pool(file_path: Optional[str] = None) -> Iterator[PeerId]:
import json

if file_path is None:
file_path = _get_default_peer_id_pool_filepath()

with open(file_path) as peer_id_pool_file:
peer_id_pool_dict = json.load(peer_id_pool_file)
for peer_id_dict in peer_id_pool_dict:
yield PeerId.create_from_json(peer_id_dict)


def _get_default_peer_id_pool_filepath():
this_file_path = os.path.dirname(__file__)
file_name = 'peer_id_pool.json'
file_path = os.path.join(this_file_path, file_name)

return file_path


PEER_ID_POOL = list(_load_peer_id_pool())

# XXX: Sync*Params classes should be inherited before the TestCase class when a sync version is needed
Expand Down