Conversation
Codecov Report
@@ Coverage Diff @@
## dev #521 +/- ##
==========================================
+ Coverage 82.81% 82.83% +0.02%
==========================================
Files 198 198
Lines 18142 18142
Branches 2564 2564
==========================================
+ Hits 15024 15028 +4
+ Misses 2554 2551 -3
+ Partials 564 563 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jansegre
requested changes
Feb 6, 2023
msbrogli
requested changes
Feb 6, 2023
Contributor
Author
@jansegre could you please re-review it? I have rolled back the |
msbrogli
approved these changes
Feb 7, 2023
jansegre
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to pass aHathorSettingsobject toCliBuilder.create_manager()to help mocking settings on tests._load_peer_id_pool(), so it's calculated. Before, with the hardcoded path, running tests from any directory other then the project root would cause errors. This prevented running specific test files from an IDE.Depends on #520.
EDIT: I have rolled back the first change as I found a better way to do it and it's not necessary anymore.