Skip to content

chore: Test Improvements#521

Merged
glevco merged 11 commits intodevfrom
chore/test-improvements
Feb 7, 2023
Merged

chore: Test Improvements#521
glevco merged 11 commits intodevfrom
chore/test-improvements

Conversation

@glevco
Copy link
Copy Markdown
Contributor

@glevco glevco commented Feb 6, 2023

  • Add ability to pass a HathorSettings object to CliBuilder.create_manager() to help mocking settings on tests.
  • Change way filepath is constructed on _load_peer_id_pool(), so it's calculated. Before, with the hardcoded path, running tests from any directory other then the project root would cause errors. This prevented running specific test files from an IDE.

Depends on #520.

EDIT: I have rolled back the first change as I found a better way to do it and it's not necessary anymore.

@glevco glevco added the enhancement New feature or request label Feb 6, 2023
@glevco glevco self-assigned this Feb 6, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2023

Codecov Report

Merging #521 (a5b432e) into dev (6a8f51e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #521      +/-   ##
==========================================
+ Coverage   82.81%   82.83%   +0.02%     
==========================================
  Files         198      198              
  Lines       18142    18142              
  Branches     2564     2564              
==========================================
+ Hits        15024    15028       +4     
+ Misses       2554     2551       -3     
+ Partials      564      563       -1     
Impacted Files Coverage Δ
hathor/p2p/node_sync.py 84.46% <0.00%> (ø)
hathor/p2p/manager.py 68.22% <0.00%> (+1.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glevco glevco changed the base branch from dev to feat/pydantic-install February 6, 2023 06:05
@glevco glevco changed the title Test Improvements chore: Test Improvements Feb 6, 2023
Copy link
Copy Markdown
Member

@jansegre jansegre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this won't work quite as expected. I'll talk to you to see a way around it. Anyway, I think the change proposed on this PR shouldn't be merged.

Base automatically changed from feat/pydantic-install to dev February 7, 2023 03:40
@glevco
Copy link
Copy Markdown
Contributor Author

glevco commented Feb 7, 2023

I think this won't work quite as expected. I'll talk to you to see a way around it. Anyway, I the change proposed on this PR shouldn't be merged.

@jansegre could you please re-review it? I have rolled back the HathorSettings change as I found a better way to do it and it's not necessary anymore.

@glevco glevco merged commit 5273310 into dev Feb 7, 2023
@glevco glevco deleted the chore/test-improvements branch February 7, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants