Merged
Conversation
|
| Branch | feat/hathorlib-blueprint-move-2 |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.66 m(-3.20%)Baseline: 1.71 m | 1.54 m (92.98%) | 2.05 m (80.66%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1606 +/- ##
==========================================
- Coverage 85.58% 85.46% -0.12%
==========================================
Files 449 449
Lines 33946 33537 -409
Branches 5309 5262 -47
==========================================
- Hits 29051 28661 -390
+ Misses 3872 3853 -19
Partials 1023 1023
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
requested changes
Mar 3, 2026
hathorlib/hathorlib/nanocontracts/blueprint_syntax_validation.py
Outdated
Show resolved
Hide resolved
hathorlib/hathorlib/nanocontracts/blueprint_syntax_validation.py
Outdated
Show resolved
Hide resolved
msbrogli
reviewed
Mar 3, 2026
msbrogli
requested changes
Mar 3, 2026
r4mmer
commented
Mar 4, 2026
msbrogli
previously approved these changes
Mar 4, 2026
… into feat/hathorlib-blueprint-move-2 * origin/feat/hathorlib-blueprint-move-2: refactor(vertex-parser): Move serialization and deserialization to vertex parser module
glevco
approved these changes
Mar 5, 2026
msbrogli
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To be able to implement the blueprint simulator on hathorlib there is a significant amount of code that needs to be moved from
hathor/tohathorlib/.Since moving this amount of code can cause instabilities we are breaking down these changes into more manageable and reviewable PRs.
This is the second PR in this sequence.
Acceptance Criteria
Extra context
Important note about HathorError:
NCFailMUST inherit fromHathorError becauseNCFailsubclasses (e.g.,OCBInvalidScript,OCBPubKeyNotAllowed,NCInvalidSignature,NCInvalidPubKey) are raised during OnChainBlueprint verification (on_chain_blueprint_verifier.py) and propagate directly tovertex_handler.py:214where they are caught byexcept HathorError. IfNCFaildid not inherit fromHathorError`, these exceptions would escape the catch block and cause unhandled errors.Therefore, both
NCFailandHathorErrormust be moved to hathorlib.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged