feat: add --test-mode-block-weight CLI flag#1609
Merged
Conversation
Expose the existing TestMode.TEST_BLOCK_WEIGHT via a CLI flag, making block mining trivial (weight=1) for integration testing. Requires --unsafe-mode, same as --test-mode-tx-weight.
jansegre
approved these changes
Mar 2, 2026
|
Bencher Report| Branch | feature/test-mode-block-weight |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.61 m(-6.17%)Baseline: 1.71 m | 1.54 m (95.92%) | 2.05 m (78.19%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
+ Coverage 85.62% 85.65% +0.03%
==========================================
Files 439 439
Lines 33515 33515
Branches 5264 5264
==========================================
+ Hits 28697 28708 +11
+ Misses 3803 3795 -8
+ Partials 1015 1012 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
approved these changes
Mar 2, 2026
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
External tests for repositories that depend on the Hathor Core should also have access to the
TestMode.TEST_BLOCK_WEIGHTthat is used in its internal tests. See RFC 102 for a concrete use case and explanations.Acceptance Criteria
TestMode.TEST_BLOCK_WEIGHTvia a CLI flag, making block mining trivial (weight=1) for integration testing. Requires--unsafe-mode, same as--test-mode-tx-weight.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged