refactor(consensus): feature activation mempool rules#1569
Merged
Conversation
08093fa to
9d02dde
Compare
7ad8bda to
8bcd974
Compare
9d02dde to
076215e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1569 +/- ##
==========================================
- Coverage 86.33% 86.27% -0.06%
==========================================
Files 437 437
Lines 33645 33662 +17
Branches 5258 5269 +11
==========================================
- Hits 29047 29042 -5
- Misses 3594 3611 +17
- Partials 1004 1009 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
approved these changes
Jan 22, 2026
e4b1772 to
9fe977f
Compare
msbrogli
previously approved these changes
Jan 23, 2026
jansegre
previously approved these changes
Jan 23, 2026
The base branch was changed.
9fe977f to
73d3e56
Compare
|
| Branch | refactor/consensus-features |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.69 m(-1.76%)Baseline: 1.72 m | 1.55 m (91.61%) | 2.06 m (81.86%) |
msbrogli
approved these changes
Jan 26, 2026
jansegre
approved these changes
Jan 26, 2026
This was referenced Jan 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1568
Motivation
In preparation for new features that will undergo the Feature Activation process, this PR performs a refactor in how the consensus handles mempool rules for feature activations.
Acceptance Criteria
ConsensusAlgorithmso it takesTransactionStorageas a dependency.ConsensusAlgorithm._compute_vertices_that_became_invalidso instead of retrieving features states individually for each feature, it uses a single_feature_activation_rules()method that takes all features into account. It uses the new unifiedFeatures.from_vertexmethod. The new use of amatchguarantees that we won't forget to add feature handling here when new features are created.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged