Conversation
e680c4f to
51d83db
Compare
cbbcbf8 to
370ce0c
Compare
glevco
commented
Jan 22, 2026
b2e984a to
a126340
Compare
1 task
7d1f967 to
7ad8bda
Compare
7ad8bda to
8bcd974
Compare
|
| Branch | refactor/features |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.70 m(-1.22%)Baseline: 1.72 m | 1.55 m (91.11%) | 2.06 m (82.32%) |
msbrogli
previously approved these changes
Jan 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1568 +/- ##
==========================================
+ Coverage 86.33% 86.34% +0.01%
==========================================
Files 437 437
Lines 33645 33652 +7
Branches 5258 5261 +3
==========================================
+ Hits 29047 29058 +11
+ Misses 3594 3590 -4
Partials 1004 1004 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
approved these changes
Jan 23, 2026
jansegre
approved these changes
Jan 23, 2026
This was referenced Jan 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In preparation for new features that will undergo the Feature Activation process, this PR performs a few refactors to simplify and unify code. Before, we were performing similar operations individually for each feature: count checkdatasig, nanos, and fee tokens. This will only grow as we add new features. Now, this handling is unified.
Acceptance Criteria
is_nano_activeandis_fee_activefunctions, and creating the newFeaturesclass, which unifies those functions in theFeatures.from_vertexmethod.Featureenum so it's aStrEnum.VerificationParamsto use the newFeaturesdataclass instead of individual attributes per feature.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged