Skip to content

refactor: feature activation handling#1568

Merged
glevco merged 2 commits intomasterfrom
refactor/features
Jan 24, 2026
Merged

refactor: feature activation handling#1568
glevco merged 2 commits intomasterfrom
refactor/features

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jan 22, 2026

Motivation

In preparation for new features that will undergo the Feature Activation process, this PR performs a few refactors to simplify and unify code. Before, we were performing similar operations individually for each feature: count checkdatasig, nanos, and fee tokens. This will only grow as we add new features. Now, this handling is unified.

Acceptance Criteria

  • Refactor Feature Activation utils, removing the is_nano_active and is_fee_active functions, and creating the new Features class, which unifies those functions in the Features.from_vertex method.
  • Refactor the Feature enum so it's a StrEnum.
  • Refactor VerificationParams to use the new Features dataclass instead of individual attributes per feature.
  • No changes in behavior.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jan 22, 2026
@glevco glevco moved this from Todo to In Progress (WIP) in Hathor Network Jan 22, 2026
@glevco glevco force-pushed the refactor/features branch 2 times, most recently from e680c4f to 51d83db Compare January 22, 2026 14:49
@glevco glevco changed the title Refactor/features refactor: feature activation handling Jan 22, 2026
@glevco glevco force-pushed the refactor/features branch 3 times, most recently from cbbcbf8 to 370ce0c Compare January 22, 2026 15:10
@glevco glevco force-pushed the refactor/features branch 5 times, most recently from b2e984a to a126340 Compare January 22, 2026 16:05
@glevco glevco force-pushed the refactor/features branch 3 times, most recently from 7d1f967 to 7ad8bda Compare January 22, 2026 18:18
@glevco glevco force-pushed the refactor/features branch from 7ad8bda to 8bcd974 Compare January 22, 2026 18:22
@glevco glevco moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jan 22, 2026
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

🐰 Bencher Report

Branchrefactor/features
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.70 m
(-1.22%)Baseline: 1.72 m
1.55 m
(91.11%)
2.06 m
(82.32%)
🐰 View full continuous benchmarking report in Bencher

msbrogli
msbrogli previously approved these changes Jan 22, 2026
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.34%. Comparing base (a010288) to head (c7dd8a7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1568      +/-   ##
==========================================
+ Coverage   86.33%   86.34%   +0.01%     
==========================================
  Files         437      437              
  Lines       33645    33652       +7     
  Branches     5258     5261       +3     
==========================================
+ Hits        29047    29058      +11     
+ Misses       3594     3590       -4     
  Partials     1004     1004              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jan 23, 2026
@glevco glevco merged commit ac49315 into master Jan 24, 2026
60 of 70 checks passed
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jan 24, 2026
@glevco glevco deleted the refactor/features branch January 24, 2026 19:39
This was referenced Jan 27, 2026
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants