Conversation
|
| Branch | feat/hathorlib |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(-2.88%)Baseline: 1.73 m | 1.56 m (92.67%) | 2.07 m (80.93%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1533 +/- ##
==========================================
- Coverage 86.28% 86.23% -0.06%
==========================================
Files 437 438 +1
Lines 33733 33744 +11
Branches 5269 5270 +1
==========================================
- Hits 29106 29098 -8
- Misses 3619 3632 +13
- Partials 1008 1014 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
previously approved these changes
Jan 2, 2026
jansegre
previously approved these changes
Jan 5, 2026
msbrogli
previously approved these changes
Jan 6, 2026
jansegre
approved these changes
Jan 7, 2026
msbrogli
approved these changes
Jan 7, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The python-hathorlib repository was created so tx-mining-service could use transaction parsing functionality without requiring the entire hathor-core.
In the near future, the hathor-lib will include additional utilities that will be used by external projects and hathor-core.
Managing duplicated code across these projects would becode increasingly difficult, so we are migrating the code to eliminate current duplication nad prevent future duplication.
Acceptance Criteria
Updates on hathor-core pyproject:
configargparseversionmultidictsub-dependency to avoid build issuesChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged