Skip to content

feat: move hathorlib to hathor-core#1533

Merged
r4mmer merged 10 commits intomasterfrom
feat/hathorlib
Jan 7, 2026
Merged

feat: move hathorlib to hathor-core#1533
r4mmer merged 10 commits intomasterfrom
feat/hathorlib

Conversation

@r4mmer
Copy link
Member

@r4mmer r4mmer commented Dec 29, 2025

Motivation

The python-hathorlib repository was created so tx-mining-service could use transaction parsing functionality without requiring the entire hathor-core.
In the near future, the hathor-lib will include additional utilities that will be used by external projects and hathor-core.
Managing duplicated code across these projects would becode increasingly difficult, so we are migrating the code to eliminate current duplication nad prevent future duplication.

Acceptance Criteria

  • Move python-hathorlib code into this repository
  • Create separate github action for linting, checks and tests on hathorlib
  • Add tool sections for mypy and pytest on hathorlib pyproject to avoid searching configs on parent directory

Updates on hathor-core pyproject:

  • Update yanked configargparse version
  • Update locked multidict sub-dependency to avoid build issues

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@r4mmer r4mmer self-assigned this Dec 29, 2025
@r4mmer r4mmer moved this from Todo to In Progress (Done) in Hathor Network Dec 29, 2025
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

🐰 Bencher Report

Branchfeat/hathorlib
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.68 m
(-2.88%)Baseline: 1.73 m
1.56 m
(92.67%)
2.07 m
(80.93%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.23%. Comparing base (44a8bb4) to head (c62e328).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1533      +/-   ##
==========================================
- Coverage   86.28%   86.23%   -0.06%     
==========================================
  Files         437      438       +1     
  Lines       33733    33744      +11     
  Branches     5269     5270       +1     
==========================================
- Hits        29106    29098       -8     
- Misses       3619     3632      +13     
- Partials     1008     1014       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jansegre
jansegre previously approved these changes Jan 2, 2026
@r4mmer r4mmer moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jan 5, 2026
jansegre
jansegre previously approved these changes Jan 5, 2026
msbrogli
msbrogli previously approved these changes Jan 6, 2026
r4mmer added 3 commits January 6, 2026 16:25
* origin/master:
  Feat(dynamic-transaction-model): fee based tokens feature activation  (#1521) (#1483)
  fix: nc-fail should not count for excluding conflicts from mempool
  chore(ci): update macos (#1474)
@r4mmer r4mmer dismissed stale reviews from msbrogli and jansegre via c62e328 January 7, 2026 14:57
@r4mmer r4mmer merged commit 681a4ef into master Jan 7, 2026
12 checks passed
@r4mmer r4mmer deleted the feat/hathorlib branch January 7, 2026 16:11
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Jan 7, 2026
@jansegre jansegre mentioned this pull request Jan 14, 2026
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jan 21, 2026
@jansegre jansegre mentioned this pull request Jan 21, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants