Skip to content

Feat(dynamic-transaction-model): Bump python-hathorlib, and fix the supported headers list in the vertex parser#1483

Merged
raul-oliveira merged 1 commit intomasterfrom
fix/push-tx-with-fee-header
Jan 7, 2026
Merged

Feat(dynamic-transaction-model): Bump python-hathorlib, and fix the supported headers list in the vertex parser#1483
raul-oliveira merged 1 commit intomasterfrom
fix/push-tx-with-fee-header

Conversation

@raul-oliveira
Copy link
Contributor

@raul-oliveira raul-oliveira commented Nov 3, 2025

Motivation

The push_tx API isn't supporting the fee header due to the absence of FeeHeader in the supported_headers list.

Trace

The vertex parser used by cls.create_from_struct (with cls being Tx/TokenCreationTx) when deserializing a transaction that arrived through the push_tx API.

Acceptance Criteria

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🐰 Bencher Report

Branchfix/push-tx-with-fee-header
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.68 m
(-2.95%)Baseline: 1.73 m
1.56 m
(92.73%)
2.07 m
(80.88%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.33%. Comparing base (44a8bb4) to head (794b3eb).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hathor/transaction/vertex_parser.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
+ Coverage   86.28%   86.33%   +0.04%     
==========================================
  Files         437      438       +1     
  Lines       33733    33744      +11     
  Branches     5269     5270       +1     
==========================================
+ Hits        29106    29132      +26     
+ Misses       3619     3605      -14     
+ Partials     1008     1007       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

glevco
glevco previously approved these changes Nov 3, 2025
@raul-oliveira raul-oliveira force-pushed the fix/push-tx-with-fee-header branch from a810e07 to 49c07c0 Compare December 15, 2025 17:45
@raul-oliveira raul-oliveira self-assigned this Dec 16, 2025
@raul-oliveira raul-oliveira moved this from Todo to In Review (WIP) in Hathor Network Dec 16, 2025
@raul-oliveira raul-oliveira changed the title Feat(dyanmic-transaction-model): Bump python-hathorlib, and fix the supported headers list in the vertex parser Feat(dynamic-transaction-model): Bump python-hathorlib, and fix the supported headers list in the vertex parser Dec 18, 2025
@raul-oliveira raul-oliveira force-pushed the fix/push-tx-with-fee-header branch from 49c07c0 to e569436 Compare December 18, 2025 00:32
@raul-oliveira raul-oliveira requested a review from glevco December 18, 2025 16:40
@raul-oliveira raul-oliveira moved this from In Review (WIP) to In Progress (Done) in Hathor Network Dec 18, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Dec 18, 2025
@raul-oliveira raul-oliveira force-pushed the fix/push-tx-with-fee-header branch from ef539b3 to 72ef380 Compare December 19, 2025 02:00
@raul-oliveira raul-oliveira requested a review from glevco December 19, 2025 02:15
@raul-oliveira raul-oliveira force-pushed the fix/push-tx-with-fee-header branch 2 times, most recently from d315969 to addbeae Compare December 19, 2025 17:13
@raul-oliveira raul-oliveira force-pushed the fix/push-tx-with-fee-header branch from addbeae to 0f1a6b0 Compare December 24, 2025 06:45
@raul-oliveira raul-oliveira force-pushed the fix/push-tx-with-fee-header branch from 0f1a6b0 to 25e95a4 Compare January 5, 2026 16:14
@raul-oliveira raul-oliveira requested a review from glevco January 5, 2026 16:15
msbrogli
msbrogli previously approved these changes Jan 5, 2026
@raul-oliveira raul-oliveira force-pushed the fix/push-tx-with-fee-header branch from 25e95a4 to 88710ba Compare January 5, 2026 18:47
@raul-oliveira raul-oliveira enabled auto-merge (squash) January 5, 2026 18:48
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jan 5, 2026
@raul-oliveira raul-oliveira force-pushed the fix/push-tx-with-fee-header branch 2 times, most recently from dafb7d6 to a024212 Compare January 5, 2026 23:03
glevco
glevco previously approved these changes Jan 6, 2026
@raul-oliveira raul-oliveira force-pushed the fix/push-tx-with-fee-header branch from a024212 to dca4b7a Compare January 7, 2026 12:50
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Jan 7, 2026
@raul-oliveira raul-oliveira merged commit 852c45b into master Jan 7, 2026
8 checks passed
@raul-oliveira raul-oliveira deleted the fix/push-tx-with-fee-header branch January 7, 2026 14:09
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Jan 7, 2026
r4mmer added a commit that referenced this pull request Jan 7, 2026
* origin/master:
  Feat(dynamic-transaction-model): fee based tokens feature activation  (#1521) (#1483)
  fix: nc-fail should not count for excluding conflicts from mempool
  chore(ci): update macos (#1474)
@jansegre jansegre mentioned this pull request Jan 14, 2026
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jan 21, 2026
@jansegre jansegre mentioned this pull request Jan 21, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants