refactor(fees): simplify fee abstractions#1469
Merged
Conversation
1 task
42802f0 to
35f899e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
- Coverage 86.13% 86.10% -0.04%
==========================================
Files 437 437
Lines 34081 33987 -94
Branches 5329 5316 -13
==========================================
- Hits 29357 29264 -93
+ Misses 3680 3678 -2
- Partials 1044 1045 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
35f899e to
fd50504
Compare
msbrogli
previously approved these changes
Oct 15, 2025
msbrogli
approved these changes
Oct 20, 2025
2 tasks
jansegre
approved these changes
Oct 20, 2025
4b04aea to
1f1aab1
Compare
|
| Branch | refactor/fees/remove-abstractions |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.73 m(-0.15%)Baseline: 1.73 m | 1.56 m (90.13%) | 2.08 m (83.21%) |
1f1aab1 to
25933e8
Compare
25933e8 to
23df2df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Simplify the fee-related logic by removing intermediary models and abstractions. This is only a code cleanup and no behavior should change.
Acceptance Criteria
matchstatements.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged