Skip to content

refactor(fees): simplify fee abstractions#1469

Merged
jansegre merged 2 commits intomasterfrom
refactor/fees/remove-abstractions
Oct 21, 2025
Merged

refactor(fees): simplify fee abstractions#1469
jansegre merged 2 commits intomasterfrom
refactor/fees/remove-abstractions

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Oct 15, 2025

Motivation

Simplify the fee-related logic by removing intermediary models and abstractions. This is only a code cleanup and no behavior should change.

Acceptance Criteria

  • Remove syscall balance rules abstractions, changing the unnecessary class polymorphism to simple functions with match statements.
  • No changes in behavior.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 15, 2025
@glevco glevco moved this from Todo to In Progress (WIP) in Hathor Network Oct 15, 2025
@glevco glevco changed the base branch from master to refactor/nano/index-records October 15, 2025 18:01
@glevco glevco changed the base branch from refactor/nano/index-records to master October 15, 2025 18:01
@glevco glevco force-pushed the refactor/fees/remove-abstractions branch 3 times, most recently from 42802f0 to 35f899e Compare October 15, 2025 18:15
@glevco glevco changed the base branch from master to refactor/nano/index-records October 15, 2025 18:15
@glevco glevco changed the base branch from refactor/nano/index-records to master October 15, 2025 18:15
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.10%. Comparing base (aea71a3) to head (23df2df).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
hathor/nanocontracts/runner/index_records.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   86.13%   86.10%   -0.04%     
==========================================
  Files         437      437              
  Lines       34081    33987      -94     
  Branches     5329     5316      -13     
==========================================
- Hits        29357    29264      -93     
+ Misses       3680     3678       -2     
- Partials     1044     1045       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco force-pushed the refactor/fees/remove-abstractions branch from 35f899e to fd50504 Compare October 15, 2025 19:47
@glevco glevco moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Oct 15, 2025
msbrogli
msbrogli previously approved these changes Oct 15, 2025
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Oct 15, 2025
@jansegre jansegre mentioned this pull request Oct 20, 2025
2 tasks
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Oct 20, 2025
@glevco glevco force-pushed the refactor/fees/remove-abstractions branch from 4b04aea to 1f1aab1 Compare October 20, 2025 17:28
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

🐰 Bencher Report

Branchrefactor/fees/remove-abstractions
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.73 m
(-0.15%)Baseline: 1.73 m
1.56 m
(90.13%)
2.08 m
(83.21%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the refactor/fees/remove-abstractions branch from 1f1aab1 to 25933e8 Compare October 20, 2025 20:47
@glevco glevco force-pushed the refactor/fees/remove-abstractions branch from 25933e8 to 23df2df Compare October 21, 2025 14:07
@jansegre jansegre merged commit 7f14adb into master Oct 21, 2025
1 of 2 checks passed
@jansegre jansegre deleted the refactor/fees/remove-abstractions branch October 21, 2025 14:09
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Oct 21, 2025
@jansegre jansegre mentioned this pull request Oct 21, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants