refactor(fees): simplify fee abstractions#1438
Closed
glevco wants to merge 14 commits intoraul-oliveira/fee-token-verificationfrom
Closed
refactor(fees): simplify fee abstractions#1438glevco wants to merge 14 commits intoraul-oliveira/fee-token-verificationfrom
glevco wants to merge 14 commits intoraul-oliveira/fee-token-verificationfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1438 +/- ##
==========================================
- Coverage 85.88% 85.81% -0.07%
==========================================
Files 431 432 +1
Lines 33274 33365 +91
Branches 5215 5223 +8
==========================================
+ Hits 28576 28633 +57
- Misses 3660 3684 +24
- Partials 1038 1048 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
refactor/fees/remove-abstractions
branch
from
f1c5abb to
25f458d
Compare
raul-oliveira
force-pushed
the
raul-oliveira/create-fee-tokens-in-nano
branch
4 times, most recently
from
7769d16 to
7a2a4eb
Compare
github-project-automation
bot
moved this from In Progress (Done)
to Waiting to be deployed
in Hathor Network
glevco
changed the base branch from
raul-oliveira/create-fee-tokens-in-nano
to
master
glevco
changed the base branch from
master
to
raul-oliveira/fee-token-verification
Co-authored-by: raul-oliveira <mrraul65@gmail.com> # Conflicts: # hathor/nanocontracts/blueprint_env.py
glevco
force-pushed
the
raul-oliveira/fee-token-verification
branch
from
a2fec5c to
1791f90
Compare
glevco
force-pushed
the
refactor/fees/remove-abstractions
branch
from
25f458d to
d6addb4
Compare
glevco
force-pushed
the
refactor/fees/remove-abstractions
branch
from
d6addb4 to
ea23e32
Compare
glevco
force-pushed
the
refactor/fees/remove-abstractions
branch
from
ea23e32 to
3fd8327
Compare
glevco
force-pushed
the
raul-oliveira/fee-token-verification
branch
5 times, most recently
from
72e231a to
dca477b
Compare
github-project-automation
bot
moved this from In Progress (WIP)
to Waiting to be deployed
in Hathor Network
Contributor
Author
|
Moved to #1469 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Simplify the fee-related logic by removing intermediary models and abstractions.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged