Skip to content

fix(nano): Method.from_callable could leak StopIteration #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jansegre merged 1 commit into from
Aug 21, 2025
Merged

fix(nano): Method.from_callable could leak StopIteration #1376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions hathor/nanocontracts/method.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,14 +246,20 @@ def from_callable(cls, method: Callable) -> Self:

# XXX: bound methods don't expose the self argument
if not is_bound_method:
self_param = next(iter_params)
try:
self_param = next(iter_params)
except StopIteration:
raise TypeError('missing self argument')
if self_param.name != 'self':
# XXX: self_param is not technically required to be named 'self', it can be named anything, but it
# should at least be a warning because it's possible the author forgot the 'self' argument
raise TypeError('first argument should be self')

if is_nc_public_method(method):
ctx_param = next(iter_params)
try:
ctx_param = next(iter_params)
except StopIteration:
raise TypeError('missing ctx argument')
if ctx_param.annotation is not Context:
raise TypeError('context argument must be annotated as `ctx: Context`')

Expand Down
Loading