fix(nano): Method.from_callable could leak StopIteration#1376
Merged
fix(nano): Method.from_callable could leak StopIteration#1376
Method.from_callable could leak StopIteration#1376Conversation
Method.from_callable could leak StopIteration
|
| Branch | fix/method-from-callable |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.86 m(+11.58%)Baseline: 1.67 m | 1.50 m (80.66%) | 2.00 m (92.98%) |
glevco
approved these changes
Aug 21, 2025
e123329 to
8a86413
Compare
msbrogli
approved these changes
Aug 21, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
- Coverage 85.70% 85.67% -0.04%
==========================================
Files 429 429
Lines 32444 32450 +6
Branches 5068 5068
==========================================
- Hits 27807 27800 -7
- Misses 3612 3621 +9
- Partials 1025 1029 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Method.from_callablecould leak aStopIterationexception in some cases where an unsupported callable was given.Acceptance Criteria
TypeErrorinstead ofStopIterationChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged