fix(cli): subcommand quick_test not stopping after #1115#1147
Merged
fix(cli): subcommand quick_test not stopping after #1115#1147
Conversation
|
Bencher Report| Branch | fix/quick_test-regression |
| Testbed | ubuntu-22.04 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot | 101,437,773,544.08 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 84.50% 84.44% -0.06%
==========================================
Files 317 317
Lines 24384 24389 +5
Branches 3707 3709 +2
==========================================
- Hits 20606 20596 -10
- Misses 3069 3076 +7
- Partials 709 717 +8 ☔ View full report in Codecov by Sentry. |
jansegre
force-pushed
the
fix/quick_test-regression
branch
from
c7cd0a7 to
4c13fdd
Compare
glevco
approved these changes
Oct 8, 2024
msbrogli
approved these changes
Oct 11, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After #1115 was merged there was a regression in the docker build CI: https://github.com/HathorNetwork/hathor-core/actions/runs/11223644493/job/31198706926 which is basically the
quick_testfailing to stop. Which happened becausequick_testmonkey-patchesHathorManger.on_new_txin order to stop, but that method is no longer used after #1115Acceptance Criteria
VertexHandlerWrapperclass that adds the stopping logic toon_new_vertexChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged