refactor(p2p): add PublicPeer and PrivatePeer to simplify Peer

[jansegre]

Motivation

The hathor.p2p.peer.Peer type represents multiple types of peers, which makes it needed to check for None on its properties and also makes it more cumbersome to check for some invariants.

Acceptance Criteria

• Split hathor.p2p.peer.Peer into Peer, PublicPeer and PrivatePeer
• Peer is just the base type with no public or private key, it implies that the peer-id cannot be verified because of the lack of a public key
• Peer is renamed to UnverifiedPeer
• PublicPeer (internally has an UnverifiedPeer) has a public-key, which can be used to verify its peer-id, it's implied that we've connected to this peer before and thus we verified its public-key
• PrivatePeer (internally has a PublicPeer) has a private-key, in practice it's only used for the node's own peer-id
• Split PeerStorage into a VerifiedPeerStorage that can only store PublicPeer and a UnverifiedPeerStorage that only stores UnverifiedPeer

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[codecov]

Codecov Report

Attention: Patch coverage is 90.36145% with 32 lines in your changes missing coverage. Please review.

Project coverage is 84.47%. Comparing base (335d050) to head (646878b).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
hathor/p2p/peer.py	93.58%	11 Missing and 1 partial ⚠️
hathor/p2p/manager.py	72.72%	7 Missing and 2 partials ⚠️
hathor/p2p/sync_v2/agent.py	70.58%	4 Missing and 1 partial ⚠️
hathor/builder/cli_builder.py	60.00%	1 Missing and 1 partial ⚠️
hathor/p2p/peer_storage.py	90.90%	2 Missing ⚠️
hathor/p2p/states/ready.py	83.33%	1 Missing ⚠️
hathor/simulator/fake_connection.py	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   84.42%   84.47%   +0.04%     
==========================================
  Files         317      317              
  Lines       24303    24366      +63     
  Branches     3698     3705       +7     
==========================================
+ Hits        20519    20582      +63     
- Misses       3070     3071       +1     
+ Partials      714      713       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bencher Report

Branch	refactor/p2p-peer-types
Testbed	ubuntu-22.04

Click to view all benchmark results

Benchmark	Latency	Benchmark Result nanoseconds (ns) (Result Δ%)	Lower Boundary nanoseconds (ns) (Limit %)	Upper Boundary nanoseconds (ns) (Limit %)
sync-v2 (up to 20000 blocks)	📈 view plot 🚷 view threshold	101,390,226,466.26 (-0.62%)	91,823,280,390.41 (90.56%)	112,228,453,810.50 (90.34%)

🐰 View full continuous benchmarking report in Bencher