refactor(static-metadata): undo migration of feature_states to static metadata

[glevco]

Motivation

A couple PRs were previously merged in preparation for migrating the feature_states attribute from "normal" metadata to static metadata (#1016, #1017). As this migration has been postponed, this PR undoes some of those previous changes such as bringing back removed tests.

Effectively, it cancels the unmerged #1018. The reason for cancelling it is that it changes the Feature Activation algorithm a bit, requiring careful review, and we don't want to invest the time in it right now. Instead, we want to merge Feature Activation for Transactions (#933) as soon as possible to begin testing it, so we're cancelling #1018 which was a dependency to it #933.

Acceptance Criteria

This PR contains 2 main changes:

1. A pure git revert of refactor(metadata): pre-refactors for migrating feature states to static metadata [part 4/12] #1017, bringing back removed test assertions (in 1aad3cc).
2. A partial revert of refactor(metadata): pre-refactors for migrating feature states to static metadata [part 3/12] #1016, bringing back a single removed test (in af8cbcf).

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[github-actions]

Bencher Report

Branch	refactor/static-metadata/undo-feature-states
Testbed	ubuntu-22.04

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
sync-v2 (up to 20000 blocks)	📈 view plot ⚠️ NO THRESHOLD	101,450,350,593.08

🐰 View full continuous benchmarking report in Bencher

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (daf12e7) to head (2d27cd1).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
- Coverage   84.51%   84.37%   -0.15%     
==========================================
  Files         317      317              
  Lines       24389    24389              
  Branches     3709     3709              
==========================================
- Hits        20612    20577      -35     
- Misses       3066     3089      +23     
- Partials      711      723      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.