fix(p2p): regression after entrypoint refactor#1088
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1088 +/- ##
==========================================
+ Coverage 84.98% 85.10% +0.11%
==========================================
Files 310 310
Lines 23495 23506 +11
Branches 3549 3551 +2
==========================================
+ Hits 19968 20005 +37
+ Misses 2824 2799 -25
+ Partials 703 702 -1 ☔ View full report in Codecov by Sentry. |
a490159 to
835b227
Compare
msbrogli
approved these changes
Jul 22, 2024
glevco
approved these changes
Jul 22, 2024
835b227 to
0a76090
Compare
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#1086 introduced a regression as can be seen in the failed docker build, during the image test
Acceptance Criteria
Entrypoint.peer_idshould default toNone(mypy didn't catch this)defer.gatherResultshad to be chained before passing it tosetProtocolMessages.PEERSdata was being constructed withEntrypointobjects, which can't be used injson.dumps, it needed to be converted tostrPeerId.__str__so it usesstr(entrypoint)instead ofrepr(entrypoint)to keep it less verboseChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged