refactor(p2p): use Entrypoint type instead of str#1086
Merged
Conversation
7d1ae72 to
53e8b8d
Compare
msbrogli
approved these changes
Jul 18, 2024
glevco
approved these changes
Jul 18, 2024
53e8b8d to
c6cce1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
- Coverage 85.08% 85.06% -0.03%
==========================================
Files 309 310 +1
Lines 23396 23468 +72
Branches 3529 3544 +15
==========================================
+ Hits 19906 19962 +56
- Misses 2790 2806 +16
Partials 700 700 ☔ View full report in Codecov by Sentry. |
c6cce1d to
2cf1908
Compare
This was referenced Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using a
stris not ideal.Acceptance Criteria
Entrypointclass that can be parsed from and converted back to thetcp://hostname:portformat, optionally allowing a peer-id (this was already supported):tcp://hostname:port/?id=peer-idHashclass that works as abyteswith fixed length of 32, to be used as base forPeerIdclass thatEntrypointuses for storing peer-ids (thisHashclass can be slowly used in more places in the future)strused as an endpoint description withEntrypointChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged