fix: profiler reactor initialization

hathor/consensus/block_consensus.py

@@ -18,15 +18,13 @@
 from structlog import get_logger
 
 from hathor.conf.get_settings import get_global_settings
-from hathor.profiler import get_cpu_profiler
 from hathor.transaction import BaseTransaction, Block, Transaction, sum_weights
 from hathor.util import classproperty
 
 if TYPE_CHECKING:
     from hathor.consensus.context import ConsensusAlgorithmContext
 
 logger = get_logger()
-cpu = get_cpu_profiler()
 
 _base_transaction_log = logger.new()
 

hathor/consensus/context.py

@@ -16,7 +16,6 @@
 
 from structlog import get_logger
 
-from hathor.profiler import get_cpu_profiler
 from hathor.pubsub import PubSubManager
 from hathor.transaction import BaseTransaction, Block
 
@@ -26,7 +25,6 @@
     from hathor.consensus.transaction_consensus import TransactionConsensusAlgorithm
 
 logger = get_logger()
-cpu = get_cpu_profiler()
 
 _base_transaction_log = logger.new()
 

hathor/consensus/transaction_consensus.py

@@ -17,15 +17,13 @@
 from structlog import get_logger
 
 from hathor.conf.get_settings import get_global_settings
-from hathor.profiler import get_cpu_profiler
 from hathor.transaction import BaseTransaction, Block, Transaction, TxInput, sum_weights
 from hathor.util import classproperty
 
 if TYPE_CHECKING:
     from hathor.consensus.context import ConsensusAlgorithmContext
 
 logger = get_logger()
-cpu = get_cpu_profiler()
 
 _base_transaction_log = logger.new()
 

hathor/profiler/cpu.py

@@ -73,7 +73,7 @@ def __init__(self, *, update_interval: float = 3.0, expiry: float = 15.0):
         self.proc_list: list[tuple[Key, ProcItem]] = []
 
         # Timer to call `self.update()` periodically.
-        self.lc_update = LoopingCall(self.update)
+        self.lc_update: LoopingCall | None = None
 
         # Interval to update the list of processes.
         self.update_interval = update_interval
@@ -102,13 +102,15 @@ def start(self) -> None:
             return
         self.reset()
         self.enabled = True
+        self.lc_update = LoopingCall(self.update)
         self.lc_update.start(self.update_interval)
 
     def stop(self) -> None:
         """Stop the profiler."""
         if not self.enabled:
             return
         self.enabled = False
+        assert self.lc_update is not None
         self.lc_update.stop()
 
     def get_proc_list(self) -> list[tuple[Key, ProcItem]]:

hathor/reactor/reactor.py

@@ -70,7 +70,9 @@ def initialize_global_reactor(*, use_asyncio_reactor: bool = False) -> ReactorPr
             msg = (
                 "There's a Twisted reactor installed already. It's probably the default one, installed indirectly by "
                 "one of our imports. This can happen, for example, if we import from the hathor module in "
-                "entrypoint-level, like in CLI tools other than `RunNode`."
+                "entrypoint-level, like in CLI tools other than `RunNode`. Debug it by setting a breakpoint in "
+                "`installReactor()` in the `twisted/internet/main.py` file."
+
             )
             raise Exception(msg) from e
 

hathor/transaction/block.py

@@ -21,7 +21,6 @@
 from hathor.checkpoint import Checkpoint
 from hathor.feature_activation.feature import Feature
 from hathor.feature_activation.model.feature_state import FeatureState
-from hathor.profiler import get_cpu_profiler
 from hathor.transaction import BaseTransaction, TxOutput, TxVersion
 from hathor.transaction.exceptions import CheckpointError
 from hathor.transaction.util import VerboseCallback, int_to_bytes, unpack, unpack_len
@@ -31,8 +30,6 @@
 if TYPE_CHECKING:
     from hathor.transaction.storage import TransactionStorage  # noqa: F401
 
-cpu = get_cpu_profiler()
-
 # Signal bits (B), version (B), outputs len (B)
 _FUNDS_FORMAT_STRING = '!BBB'
 

hathor/transaction/transaction.py

@@ -19,7 +19,6 @@
 
 from hathor.checkpoint import Checkpoint
 from hathor.exception import InvalidNewTransaction
-from hathor.profiler import get_cpu_profiler
 from hathor.reward_lock import iter_spent_rewards
 from hathor.transaction import BaseTransaction, TxInput, TxOutput, TxVersion
 from hathor.transaction.base_transaction import TX_HASH_SIZE
@@ -31,8 +30,6 @@
 if TYPE_CHECKING:
     from hathor.transaction.storage import TransactionStorage  # noqa: F401
 
-cpu = get_cpu_profiler()
-
 # Signal bits (B), version (B), token uids len (B) and inputs len (B), outputs len (B).
 _FUNDS_FORMAT_STRING = '!BBBBB'