Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
==========================================
- Coverage 84.92% 84.83% -0.10%
==========================================
Files 300 300
Lines 22944 22936 -8
Branches 3471 3471
==========================================
- Hits 19486 19458 -28
- Misses 2769 2784 +15
- Partials 689 694 +5 ☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Jun 11, 2024
ac3f0be to
8a733dd
Compare
msbrogli
approved these changes
Jul 5, 2024
msbrogli
pushed a commit
that referenced
this pull request
Jul 5, 2024
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
get_cpu_profiler()function which is called at the module-level in multiple places indirectly installed the Twisted reactor by callingLoopingCall(). This meant that when a module with a profiler was imported before reactor initialization (ininitialize_global_reactor), aReactorAlreadyInstalledErrorcould be thrown.This PR prevents the profiler from indirectly installing a reactor before it has been initialized.
Acceptance Criteria
SimpleCPUProfilerso it does not create aLoopingCallin its__init__.get_cpu_profiler().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged