fix DatePickerProps

[yuki0410-dev]

Description

Linked issue: closes #4922

Problem
See issue

Changes

• Add Partial toPick<AdditionalProps, "excludeScrollbar">
• change to optional onSelect and onChangeProps. (Consider defaultProps)

Contribution checklist

• I have followed the contributing guidelines.
• I have added sufficient test coverage for my changes.
• I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

[pullrequest]

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:

• Comments posted to any areas of potential concern or improvement.
• Detailed feedback or actions needed to resolve issues that are found.
• Turnaround times vary, but we aim to be swift.

---

@yuki0410-dev you can click here to see the review status or cancel the code review job.

[pullrequest]

PullRequest Breakdown

Reviewable lines of change

+ 43
- 24

100% TSX

Type of change

Fix - These changes are likely to be fixing a bug or issue.

[codecov]

Codecov Report

Attention: Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.

Project coverage is 96.35%. Comparing base (f90932c) to head (ee69d7b).

Files	Patch %	Lines
src/index.tsx	71.05%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4932      +/-   ##
==========================================
- Coverage   96.67%   96.35%   -0.32%     
==========================================
  Files          28       28              
  Lines        3275     3295      +20     
  Branches     1357     1392      +35     
==========================================
+ Hits         3166     3175       +9     
- Misses        109      116       +7     
- Partials        0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pullrequest]

The changes look good to me overall. I added one note about possibly simplifying the default value checks, but otherwise don't have any concerns about the updates. Thanks!

Jonah

---

Reviewed with ❤️ by PullRequest

[pullrequest]

I have no concerns with this pull request. The duplication already mentioned would be nice to have but is non-blocking.

Jacob

---

Reviewed with ❤️ by PullRequest

[martijnrusschen]

it looks like the test coverage took a hit, can you review this?

[yuki0410-dev]

@martijnrusschen
I just formally describe the fallback because defaultProps is not reflected in the type well, and I can't actually get the code to pass here.
(I can write this code well if it is a function Component instead of a Class Component.)
A similar case occurred during the typescript transition, and we believe that it cannot be helped.

[yuki0410-dev]

@martijnrusschen
Is this PR likely to merge?