Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excludScrollbar an optional property #4922

Closed
lordenas opened this issue Jun 19, 2024 · 3 comments · Fixed by #4932
Closed

excludScrollbar an optional property #4922

lordenas opened this issue Jun 19, 2024 · 3 comments · Fixed by #4932

Comments

@lordenas
Copy link

lordenas commented Jun 19, 2024

Describe the bug
excludeScrollbar - should be an optional property in DatePickerProps

To Reproduce
https://codesandbox.io/p/sandbox/datepickerprops-92df8r?file=%2Fsrc%2FApp.tsx

I want to make a wrapper for a component. To pass all its properties I use DatePickerProps from the react-datepicker import.
But the excludeScrollbar property should be an optional property

Expected behavior
excludeScrollbar - should be an optional property in DatePickerProps

@yuki0410-dev
Copy link
Contributor

@lordenas
Would this page be helpful? (It seems to be a glitch in ts.)
https://stackoverflow.com/questions/78641187/why-is-excludscrollbar-property-required-for-react-datepicker

When reproducing it at hand, I forked codesandbox, but the type error is not occurring for some reason.
https://codesandbox.io/p/sandbox/datepickerprops-forked-vzwr86

Would bringing ts up to date improve this?

@lordenas
Copy link
Author

@lordenas Would this page be helpful? (It seems to be a glitch in ts.) https://stackoverflow.com/questions/78641187/why-is-excludscrollbar-property-required-for-react-datepicker

When reproducing it at hand, I forked codesandbox, but the type error is not occurring for some reason. https://codesandbox.io/p/sandbox/datepickerprops-forked-vzwr86

Would bringing ts up to date improve this?

It's strange, but I still see the error in CodeSandox
image

@yuki0410-dev yuki0410-dev mentioned this issue Jun 22, 2024
3 tasks
@yuki0410-dev
Copy link
Contributor

I created a PR for type modification.
#4932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants