-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add .editorconfig and .prettierrc.js #4748
feat: add .editorconfig and .prettierrc.js #4748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@yuki0410-dev you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 42
- 0
62% JavaScript
36% EditorConfig
2% Ignore List
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
Test suite failures will be resolved when #4747 is merged or CI is run on another day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.editorconfig is super helpful! Be sure to direct everyone to install an extension if their editor does not natively support it — I know from personal experience that VS Code does not natively.
Overall, having consistent formatting is incredibly helpful, not the least because it makes things easier to read and eliminates a number of potential merge conflicts in the future.
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes look good to me and I am in favor of tools such as EditorConfig and Prettier for code style consistency and cleanliness. I added a suggestions for expanding upon the Prettier config to match the EditorConfig settings. That's optional but could be nice to implement at some point. Thank you!
Reviewed with ❤️ by PullRequest
@@ -0,0 +1,15 @@ | |||
# http://editorconfig.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12d42a8
to
db21628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
db21628
to
38b3756
Compare
38b3756
to
8072e18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4748 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 11 11
Lines 1462 1462
Branches 642 650 +8
=======================================
Hits 1422 1422
Misses 40 40 ☔ View full report in Codecov by Sentry. |
Description
Linked issue: #(issue number)
Problem
When creating a new file in VSCode, indentation and other settings are not set correctly and must be changed manually.
Changes
add .editorconfig file
Screenshots
To reviewers
Contribution checklist