[typescript-migration] fix types & imports #4747

yuki0410-dev · 2024-04-30T01:29:41Z

name: fix types & imports

Description

Linked issue: #4700

Changes fix types & imports

Contribution checklist

I have followed the contributing guidelines.
I have added sufficient test coverage for my changes.
I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

pullrequest

⚠️ This pull request was not sent to the PullRequest network because the pull request is a draft.

yuki0410-dev · 2024-04-30T01:30:19Z

~~#4740 will be merged and then Draft will be released.~~

yuki0410-dev · 2024-04-30T01:31:20Z

If #4743 is merged first, an additional fix will be made.

codecov · 2024-04-30T02:19:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (30d9edb) to head (4b38122).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4747   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files           8        8           
  Lines         959      959           
  Branches      435      442    +7     
=======================================
  Hits          924      924           
  Misses         35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pullrequest

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:

Comments posted to any areas of potential concern or improvement.
Detailed feedback or actions needed to resolve issues that are found.
Turnaround times vary, but we aim to be swift.

@yuki0410-dev you can click here to see the review status or cancel the code review job.

pullrequest

PullRequest Breakdown

Reviewable lines of change

+ 278
- 237

89% TSX
10% TypeScript
1% JavaScript (tests)

Type of change

Fix - These changes are likely to be fixing a bug or issue.

pullrequest

Just one nit about possible extraneous annotations. Other than that, the PR looks good! All annotations seem correct, so my nit is certainly not blocking.

Jacob

Reviewed with ❤️ by PullRequest

pullrequest · 2024-04-30T03:37:22Z

src/year_dropdown.tsx

-    const maxYear = this.props.maxDate ? getYear(this.props.maxDate) : 2100;
-
-    const options = [];
+    const minYear: number = this.props.minDate


Is this annotation necessary? It seems like it should be trivially inferred based on the arms, and it shouldn't be confusing to humans due to the presence of a numeric literal.

🔹 Simplify Code (Nice to have)

Jacob

Thanks for the review.
I thought it would be better to state explicitly here that I want to get a NUMBER (without resorting to inference) from the results of multiple conditional branches.

pullrequest

I looked over this pull request thoroughly, but it was difficult to find any problems with it. Nice work! I appreciated the attention to detail and simplification of imports and code throughout the changes.

Jonah S

Reviewed with ❤️ by PullRequest

pullrequest · 2024-04-30T04:35:05Z

src/date_utils.ts

@@ -55,11 +55,16 @@ import { isWithinInterval } from "date-fns/isWithinInterval";
 import { toDate } from "date-fns/toDate";
 import { parse } from "date-fns/parse";
 import { parseISO } from "date-fns/parseISO";
-import { type Locale, addSeconds, Day } from "date-fns";
+import { type Locale as DateFnsLocale, addSeconds, Day } from "date-fns";


Thank you for disambiguating the date-fns Locale and the date_utils Locale!

◽ Compliment

Jonah S

pullrequest

PullRequest reviewed the updates made to #4747 since our last review was posted. This includes comments that have been posted by non-PullRequest reviewers. No further issues were found.

Reviewed by:

Jacob

martijnrusschen · 2024-05-03T14:15:59Z

Looks like there're some conflicts on this one.

pullrequest

PullRequest reviewed the updates made to #4747 since our last review was posted. This includes comments that have been posted by non-PullRequest reviewers. No further issues were found.

Reviewed by:

Jonah S

yuki0410-dev · 2024-05-03T15:36:45Z

@martijnrusschen
Rebased and fixed.

pullrequest

PullRequest reviewed the updates made to #4747 up until the latest commit (d897045). No further issues were found.

Reviewed by:

Jonah S

yuki0410-dev · 2024-05-03T15:41:22Z

error - 2024-05-03 15:39:57,426 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 40 seconds."}
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

yuki0410-dev · 2024-05-03T15:47:24Z

@martijnrusschen
Rebased and passed all ci.

pullrequest bot reviewed Apr 30, 2024

View reviewed changes

yuki0410-dev force-pushed the feat/4700_types branch 2 times, most recently from 4efe60e to 286ff81 Compare April 30, 2024 02:17

yuki0410-dev force-pushed the feat/4700_types branch from 286ff81 to 956f3bc Compare April 30, 2024 02:35

yuki0410-dev mentioned this pull request Apr 30, 2024

feat: add .editorconfig and .prettierrc.js #4748

Merged

3 tasks

yuki0410-dev force-pushed the feat/4700_types branch from 956f3bc to 20d147b Compare April 30, 2024 02:55

yuki0410-dev marked this pull request as ready for review April 30, 2024 03:15

pullrequest bot reviewed Apr 30, 2024

View reviewed changes

yuki0410-dev mentioned this pull request Apr 30, 2024

[typescript-migration] add type-check to gh actions #4749

Merged

3 tasks

pullrequest bot reviewed May 3, 2024

View reviewed changes

yuki0410-dev force-pushed the feat/4700_types branch from 20d147b to d897045 Compare May 3, 2024 15:31

pullrequest bot reviewed May 3, 2024

View reviewed changes

feat: fix types

4b38122

yuki0410-dev force-pushed the feat/4700_types branch from d897045 to 4b38122 Compare May 3, 2024 15:45

martijnrusschen merged commit 27829c7 into Hacker0x01:main May 3, 2024
6 checks passed

yuki0410-dev deleted the feat/4700_types branch May 3, 2024 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[typescript-migration] fix types & imports #4747

[typescript-migration] fix types & imports #4747

yuki0410-dev commented Apr 30, 2024

pullrequest bot left a comment

yuki0410-dev commented Apr 30, 2024 •

edited

Loading

yuki0410-dev commented Apr 30, 2024

codecov bot commented Apr 30, 2024 •

edited

Loading

pullrequest bot left a comment

pullrequest bot left a comment •

edited

Loading

pullrequest bot left a comment

pullrequest bot Apr 30, 2024

yuki0410-dev Apr 30, 2024

pullrequest bot left a comment

pullrequest bot Apr 30, 2024

pullrequest bot left a comment

martijnrusschen commented May 3, 2024

pullrequest bot left a comment

yuki0410-dev commented May 3, 2024

pullrequest bot left a comment

yuki0410-dev commented May 3, 2024

yuki0410-dev commented May 3, 2024

[typescript-migration] fix types & imports #4747

[typescript-migration] fix types & imports #4747

Conversation

yuki0410-dev commented Apr 30, 2024

name: fix types & imports

Description

Contribution checklist

pullrequest bot left a comment

Choose a reason for hiding this comment

yuki0410-dev commented Apr 30, 2024 • edited Loading

yuki0410-dev commented Apr 30, 2024

codecov bot commented Apr 30, 2024 • edited Loading

Codecov Report

pullrequest bot left a comment

Choose a reason for hiding this comment

pullrequest bot left a comment • edited Loading

Choose a reason for hiding this comment

PullRequest Breakdown

pullrequest bot left a comment

Choose a reason for hiding this comment

pullrequest bot Apr 30, 2024

Choose a reason for hiding this comment

🔹 Simplify Code (Nice to have)

yuki0410-dev Apr 30, 2024

Choose a reason for hiding this comment

pullrequest bot left a comment

Choose a reason for hiding this comment

pullrequest bot Apr 30, 2024

Choose a reason for hiding this comment

◽ Compliment

pullrequest bot left a comment

Choose a reason for hiding this comment

martijnrusschen commented May 3, 2024

pullrequest bot left a comment

Choose a reason for hiding this comment

yuki0410-dev commented May 3, 2024

pullrequest bot left a comment

Choose a reason for hiding this comment

yuki0410-dev commented May 3, 2024

yuki0410-dev commented May 3, 2024

yuki0410-dev commented Apr 30, 2024 •

edited

Loading

codecov bot commented Apr 30, 2024 •

edited

Loading

pullrequest bot left a comment •

edited

Loading