feat: #3798 Replaced classnames with clsx

[yuki0410-dev]

Description

Linked issue: close #3798

Problem
See issue #3798

Changes
Replaced classnames with clsx

Screenshots

To reviewers

Contribution checklist

• I have followed the contributing guidelines.
• I have added sufficient test coverage for my changes.
• I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

[pullrequest]

✅ This pull request was sent to the PullRequest network.

---

@yuki0410-dev you can click here to see the review status or cancel the code review job.

[pullrequest]

PullRequest Breakdown

Reviewable lines of change

+ 30
- 39

91% JavaScript
6% JavaScript (tests)
3% JSON

Generated lines of change

+ 5
- 5

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (009efaf) to head (c9bb7fd).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4632   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files          28       28           
  Lines        2607     2607           
  Branches     1101     1101           
=======================================
  Hits         2528     2528           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pullrequest]

This change does what the description says - no security issues here.

Jacques

---

Reviewed with ❤️ by PullRequest

[pullrequest]

These changes look good to me as well for upgrading to the more modern clsx. I didn't notice any issues with the upgrade.

At a quick glance, I did notice here that there is a globals entry for classnames, but provided that all package.json scripts are still running successfully after this upgrade, I don't think that should be addressed in this PR.

Nice work with this one! Another great improvement.

Ryan

---

Reviewed with ❤️ by PullRequest

[yuki0410-dev]

Thanks for the review.

I removed classnames from global in rollup.config.mjs.
The clsx did not affect the build result whether it was present in globals or not.

[pullrequest]

PullRequest reviewed the updates made to #4632 up until the latest commit (c9bb7fd). No further issues were found.

Reviewed by:

Ryan

[martijnrusschen]

Thanks this looks good.