Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace clasnames with clsx #3798

Closed
MaximBG opened this issue Oct 20, 2022 · 0 comments · Fixed by #4632
Closed

Replace clasnames with clsx #3798

MaximBG opened this issue Oct 20, 2022 · 0 comments · Fixed by #4632

Comments

@MaximBG
Copy link

MaximBG commented Oct 20, 2022

Could you please consider replacement of classnames library with clsx?
After react-grid-layout did the replacement react-datepicker is the last library in my dependencies that still uses classnames.

"Now, as a free tip to at least 2x the performance of the thousands of classNames calls you probably make, just switch to clsx. It’s a similar library to classNames, but a bit more fresh-y, and with even fewer LOCs.

The API is identical to the classNames one, but without the additional versions (which you probably don’t need anyway). And while the performance gains might not be noticeable, it still means that there’s speed left on the table, and the multitude of calls can quickly add up to something more."

https://areknawo.com/you-dont-know-the-classnames-library/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant