fix: #4561 remove triangle-arrow-up/down mixin #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@yuki0410-dev you can click here to see the review status or cancel the code review job.
yuki0410-dev
commented
Mar 17, 2024
| @@ -17,4 +17,3 @@ $datepicker__font-family: "Helvetica Neue", helvetica, arial, sans-serif !defaul | |||
| $datepicker__item-size: 1.7rem !default; | |||
| $datepicker__margin: 0.4rem !default; | |||
| $datepicker__navigation-button-size: 32px !default; | |||
| $datepicker__triangle-size: 8px !default; | |||
There was a problem hiding this comment.
unused variable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4604 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 28 28
Lines 2582 2582
Branches 1081 1081
=======================================
Hits 2503 2503
Misses 79 79 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #4561
Problem
See issue #4561
Changes
Removed triangle-arrow mixin and moved style.
The fill and color were left as they are now, as it is correct that the fill and color are different for up and down.
(The colors of the contact datepicker body location are not aligned with the up and down locations.)
The inline color code issue is not addressed in this PR.
Screenshots
To reviewers
Contribution checklist