-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different styles for Up and Down arrows #4561
Comments
@abdulhadi-lababidi98 |
fix: #4561 remove triangle-arrow-up/down mixin
Okay I see the misunderstanding here, for our use case we have dark theme, so having
And it works perfectly when the date picker placement is on the bottom but when it's on the top it switches to white (if I didn't write custom style for that) And to fix the issue I had to write this custom styling:
So my suggestion is to add another scss variable called something like
I can open a new PR in my next iteration to make that happen, but I wanna make sure that I'm not missing something here. wdyt? @yuki0410-dev |
Is your feature request related to a problem? Please describe.
In multiple places the color
#fff
is used in the library and there is no way to control that except of overriding the the CSS rule with some selectors and!important
flag, which is not the best.Some examples:
src/stylesheets/mixins.scss
So I'm wondering here why the
fill
andcolor
are not the same for bothup
anddown
arrows?src/stylesheets/datepicker.scss
you can find multiple examples like this:Describe the solution you'd like
src/stylesheets/mixins.scss
I suggest removing thetriangle-arrow-up
andtriangle-arrow-down
mixins since we don't really need them anymore and the arrow style now is controlled by inline CSS.Additional Context
div
with theafter
andbefore
pseudo-elements with a lot of CSS, To a simple SVG element. So I don't think we need thetriangle-arrow-[up/down]
mixins anymoreThe text was updated successfully, but these errors were encountered: