Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum Feet Width #1261

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Minimum Feet Width #1261

merged 2 commits into from
Jul 17, 2024

Conversation

schluis
Copy link
Contributor

@schluis schluis commented Jul 16, 2024

Why? What?

  • Filter feet obstacles, which are only a few pixels wide.
  • Store leftmost and rightmost point in CountedClusters, filter clusterwidth

Without:

image

With:

image

Ideas for Next Iterations (Not This PR)

How to Test

  • Check false-positives in feet detection

@schluis schluis enabled auto-merge July 16, 2024 19:45
julianschuler
julianschuler requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@julianschuler julianschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a full review yet, I have to test this tomorrow.

julianschuler
julianschuler requested changes Jul 17, 2024
View reviewed changes
crates/types/src/detected_feet.rs Outdated Show resolved Hide resolved
@schluis schluis added this pull request to the merge queue Jul 17, 2024
Merged via the queue into HULKs:main with commit 3b4432a Jul 17, 2024
25 checks passed
@schluis schluis deleted the wide-feet-only branch July 17, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianschuler julianschuler julianschuler approved these changes

Assignees

@julianschuler julianschuler

Labels
cat:Vision
Projects
Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schluis @julianschuler