Also consider SubState::PenaltyKick and kicking_team for keeper localization #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaikRe
requested changes
Jul 16, 2024
schluis
force-pushed
the
keeper-position-in-shootout
branch
from
9998cf8
to
5c3c966
Compare
schluis
force-pushed
the
keeper-position-in-shootout
branch
from
5c3c966
to
ed768f1
Compare
schluis
force-pushed
the
keeper-position-in-shootout
branch
from
ed768f1
to
16eb707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
Fixes #1165
ToDo
How to Test
Check localization of keeper during penalty kick for opponent team