Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 2020 queries #1098

Merged
merged 61 commits into from
Sep 23, 2020
Merged

HTTP/2 2020 queries #1098

merged 61 commits into from
Sep 23, 2020

Conversation

gregorywolf
Copy link
Contributor

@gregorywolf gregorywolf commented Jul 25, 2020

Progress on #921

All queries have been updated to use the almanac data set

  • - adoption_of_http_2_by_site_and_requests.sql
  • - avg_number_of_h2_pushed_resources_and_avg_bytes.sql
  • - avg_number_of_h2_pushed_resources_and_avg_bytes_by_content_type.sql
  • - avg_percent_of_resources_loaded_over_h2_or_h1_1_per_site.sql
  • - count_of_h2_sites_grouped_by_server.sql
  • - count_of_h2_sites_using_h2_push.sql
  • - count_of_non_h2_sites_grouped_by_server.sql
  • - count_of_preload_http_headers_with_nopush_attribute_set.sql
  • - detailed_alt_svc_headers.sql
  • - detailed_upgrade_headers.sql
  • - measure_number_of_tcp_connections_per_site.sql
  • - measure_of_all_http_versions_for_main_page_of_all_sites.sql
  • - number_of_http_sites_returning_upgrade_http_header_containing_h2.sql
  • - number_of_https_sites_not_using_h2_returning_upgrade_http_upgrade_header_containing_h2.sql
  • - number_of_https_sites_using_h2_returning_upgrade_http_header_containing_h2.sql
  • - percent_of_sites_affected_by_cdn_prioritization_issues.sql
  • - tls_1_3_adoption_for_h2

- Copy of all 2019 SQL queries in a single file

- Initial SQL query using sample_data
Updated 2019 SQL using sample_data
@rviscomi rviscomi changed the title Initial SQL Formatted Queries from 2019 HTTP/2 2020 queries Jul 25, 2020
@rviscomi rviscomi added the analysis Querying the dataset label Jul 25, 2020
@rviscomi rviscomi added this to the 2020 Analysis milestone Jul 25, 2020
@rviscomi
Copy link
Member

rviscomi commented Jul 25, 2020

Thanks @gregorywolf! Could you edit the PR description to include a checklist of the metrics needed by the chapter and check off the ones implemented in this PR so far? This will help us see at a glance how much work is still left to do.

@gregorywolf
Copy link
Contributor Author

@rviscomi I have updated the PR description as requested. I have also extracted out some suggested metrics from the chapter discussion which I need to determine how to generate. Any assistance would be much appreciated :)

@tunetheweb
Copy link
Member

tunetheweb commented Jul 26, 2020

Hey @gregorywolf I've edited the initial comment to convert your SUCCESS/FAILS to tick boxes. This then shows how complete they are (14 out of 20) when looking at the issue:

Issue status

As to your other queries:

How many sites offer H3 by looking at the alt-svc headers

Take a look at 20_04 from last year and 20_04a from last year

TLS 1.3 adoption for H2

That should be easy enough to get. Look at HTTP/2 queries and Security queries from last year.

How many HTTP Headers are sent
Size of HTTP headers

Again 20_04 from last year might give you a way to get started with this.

We also wanted a way to measure HPACK gains, but I asked about this last year and it wasn't possible then so doubt it's possible now.

Hope that helps!

@rviscomi
Copy link
Member

Thanks @gregorywolf!

@gregorywolf gregorywolf reopened this Sep 10, 2020
@tunetheweb
Copy link
Member

@gregorywolf please see this comment about the fact the prioritisation table has been renamed and dated now.

Copy link
Contributor Author

@gregorywolf gregorywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the name of the table to be used in the query

Corrected the table name for the CDN prioritization query
Added a new line at end of queries
@gregorywolf gregorywolf marked this pull request as ready for review September 11, 2020 21:34
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some early feedback after looking at the first few queries. The comments apply to the other queries as well.

@tunetheweb tunetheweb requested a review from a team September 11, 2020 21:53
Updated all of the queries based on feedback from Rick V
…t_of_non_h2_and_h3_sites_grouped_by_server.sql
…number_of_h2_and h3_pushed_resources_and_bytes_transferred.sql
…ent_type.sql to number_of_h2_and_h3_pushed_resources_and_bytes_by_content_type.sql
…ues.sql to percentage_of_h2_and_h3_sites_affected_by_cdn_prioritization.sql
…rade_http_upgrade_header_containing_h2.sql to number_of_https_requests_not_using_h2_or_h3_returning_upgrade_http_upgrade_header_containing_h2.sql
Copy link
Contributor Author

@gregorywolf gregorywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes made

Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results for all queries, including suggestions, saved to the chapter sheet.

One outstanding question about CDN chains that may require rerunning the query.

@rviscomi
Copy link
Member

With the CDN discussion resolved, all of the queries have been reviewed and their results saved to the sheet, so this PR should be ready to merge and the HTTP/2 chapter should now be ready for the content team to review the results and start writing! 🎉 📝

@rviscomi rviscomi merged commit 0a91453 into HTTPArchive:main Sep 23, 2020
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments from me but happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Querying the dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants