-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP/2 2020 queries #1098
HTTP/2 2020 queries #1098
Conversation
Thanks @gregorywolf! Could you edit the PR description to include a checklist of the metrics needed by the chapter and check off the ones implemented in this PR so far? This will help us see at a glance how much work is still left to do. |
@rviscomi I have updated the PR description as requested. I have also extracted out some suggested metrics from the chapter discussion which I need to determine how to generate. Any assistance would be much appreciated :) |
Hey @gregorywolf I've edited the initial comment to convert your SUCCESS/FAILS to tick boxes. This then shows how complete they are (14 out of 20) when looking at the issue: As to your other queries:
Take a look at 20_04 from last year and 20_04a from last year
That should be easy enough to get. Look at HTTP/2 queries and Security queries from last year.
Again 20_04 from last year might give you a way to get started with this. We also wanted a way to measure HPACK gains, but I asked about this last year and it wasn't possible then so doubt it's possible now. Hope that helps! |
Thanks @gregorywolf! |
Changes reflect the updated August RUN
@gregorywolf please see this comment about the fact the prioritisation table has been renamed and dated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the name of the table to be used in the query
Corrected the table name for the CDN prioritization query Added a new line at end of queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Some early feedback after looking at the first few queries. The comments apply to the other queries as well.
sql/2020/22_HTTP_2/avg_number_of_h2_pushed_resources_and_avg_bytes.sql
Outdated
Show resolved
Hide resolved
sql/2020/22_HTTP_2/avg_number_of_h2_pushed_resources_and_avg_bytes.sql
Outdated
Show resolved
Hide resolved
sql/2020/22_HTTP_2/avg_number_of_h2_pushed_resources_and_avg_bytes.sql
Outdated
Show resolved
Hide resolved
Updated all of the queries based on feedback from Rick V
…t_of_non_h2_and_h3_sites_grouped_by_server.sql
…number_of_h2_and h3_pushed_resources_and_bytes_transferred.sql
…ent_type.sql to number_of_h2_and_h3_pushed_resources_and_bytes_by_content_type.sql
…ues.sql to percentage_of_h2_and_h3_sites_affected_by_cdn_prioritization.sql
…rade_http_upgrade_header_containing_h2.sql to number_of_https_requests_not_using_h2_or_h3_returning_upgrade_http_upgrade_header_containing_h2.sql
…r_site.sql to percentage_of_resources_loaded_over_HTTP_by_version_per_site.sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes made
sql/2020/22_HTTP_2/number_of_h2_and_h3_pushed_resources_and_bytes_by_content_type.sql
Outdated
Show resolved
Hide resolved
sql/2020/22_HTTP_2/number_of_http_requests_returning_upgrade_http_header_containing_h2.sql
Outdated
Show resolved
Hide resolved
...of_https_requests_not_using_h2_or_h3_returning_upgrade_http_upgrade_header_containing_h2.sql
Outdated
Show resolved
Hide resolved
.../22_HTTP_2/number_of_https_requests_using_h2_returning_upgrade_http_header_containing_h2.sql
Outdated
Show resolved
Hide resolved
sql/2020/22_HTTP_2/percentage_of_resources_loaded_over_HTTP_by_version_per_site.sql
Outdated
Show resolved
Hide resolved
…tes_by_content_type.sql Co-authored-by: Rick Viscomi <[email protected]>
…ttp_header_containing_h2.sql Co-authored-by: Rick Viscomi <[email protected]>
…_returning_upgrade_http_upgrade_header_containing_h2.sql Co-authored-by: Rick Viscomi <[email protected]>
…_upgrade_http_header_containing_h2.sql Co-authored-by: Rick Viscomi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Results for all queries, including suggestions, saved to the chapter sheet.
One outstanding question about CDN chains that may require rerunning the query.
sql/2020/22_HTTP_2/number_of_h2_and_h3_pushed_resources_and_bytes_by_content_type.sql
Outdated
Show resolved
Hide resolved
sql/2020/22_HTTP_2/percentage_of_h2_and_h3_sites_affected_by_cdn_prioritization.sql
Show resolved
Hide resolved
sql/2020/22_HTTP_2/percentage_of_resources_loaded_over_HTTP_by_version_per_site.sql
Outdated
Show resolved
Hide resolved
…tes_by_content_type.sql Co-authored-by: Rick Viscomi <[email protected]>
…_version_per_site.sql Co-authored-by: Rick Viscomi <[email protected]>
With the CDN discussion resolved, all of the queries have been reviewed and their results saved to the sheet, so this PR should be ready to merge and the HTTP/2 chapter should now be ready for the content team to review the results and start writing! 🎉 📝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments from me but happy to merge.
Progress on #921
All queries have been updated to use the almanac data set