fix(skills): make weather workflow Windows-safe - #5341
Open
mercael91 wants to merge 1 commit into
Open
Conversation
On Windows PowerShell, bare `curl` may resolve to the `Invoke-WebRequest` alias instead of the native cURL executable. This causes the first weather command to fail, requiring the agent to retry with `curl.exe`. Changes: - Add platform notes documenting Windows PowerShell vs macOS/Linux difference - Use explicit HTTPS URLs for wttr.in requests - Add single `?1&m` request for today's weather to avoid redundant calls - Use cross-platform output path (weather.png instead of /tmp/weather.png) - Add regression test for the weather skill guidance Signed-off-by: mercael <mercael91@gmail.com>
chengyongru
added
priority: p2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows PowerShell, bare
curlmay resolve to theInvoke-WebRequestalias instead of the native cURL executable.The weather skill previously used bare
curlin its examples. This could cause the first weather command to fail, requiring the agent to analyze the error and retry withcurl.exe.Closes #5303
Changes
?1&mrequest for today's weather to avoid redundant callsweather.pnginstead of/tmp/weather.png)Testing
pytest tests/agent/test_builtin_weather_skill.py -v— 1 passed