fix(skills): make weather workflow Windows-safe - #5303
Merged
Conversation
This was referenced Aug 10, 2026
Re-bin
force-pushed
the
fix/windows-weather-workflow
branch
from
August 11, 2026 15:13
d80b9c6 to
2011668
Compare
Re-bin
force-pushed
the
fix/windows-weather-workflow
branch
from
August 11, 2026 17:40
2011668 to
9d2a922
Compare
Re-bin
approved these changes
Aug 11, 2026
Re-bin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The built-in weather workflow now uses Windows-safe PowerShell commands, HTTPS assets, and platform-neutral output guidance, backed by focused skill regression tests.
Verified against the current main; all required checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows PowerShell, bare
curlmay resolve to theInvoke-WebRequestalias instead of the native cURL executable.The weather skill previously used bare
curlin its examples. This could cause the first weather command to fail, requiring the agent to analyze the error and retry withcurl.exe. Requests for today's weather could also trigger separate current-condition and daily-forecast calls.These retries introduce avoidable tool calls, LLM iterations, latency, and token usage.
Changes
curl.exefor weather requests on Windows PowerShell?1&mrequest for today's weatherResult
Manual verification with “北京今天天气怎么样?” confirmed that the agent directly called:
This avoids the failed bare
curlattempt, the follow-up recovery iteration, and a redundant separate current-weather request, reducing avoidable response latency and token usage.Testing
pytest tests/agent/test_builtin_weather_skill.py -v— 1 passedpytest tests/agent/test_context_builder.py -q— 49 passedruff check tests/agent/test_builtin_weather_skill.py— all checks passednanobot agent --logs -s cli:weather-skill-testcurl.exe -s "https://wttr.in/Beijing?1&m"curlattempt or redundant current-weather request occurred