-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event sign in endpoint (Ready for review) #44
Commits on Aug 13, 2020
-
Adding event sign in endpoint (WIP).
Thai committedAug 13, 2020 2Configuration menu - View commit details
-
Copy full SHA for 648f7d9 - Browse repository at this point
Copy the full SHA 648f7d9View commit details -
Changed AppUserEventSignInRequest/Response to EventSignInRequest/Resp…
…onse. Also removed agreeToPhotoRelease in EventSignInRequest for now.
Thai committedAug 13, 2020 Configuration menu - View commit details
-
Copy full SHA for 0a41cb9 - Browse repository at this point
Copy the full SHA 0a41cb9View commit details -
Set up everything for registering attendance for signed in user (WIP).
I still don't know what to do if the AppUser's role is an affiliate role (so inductee, member, officer, anything that is not guest). Might just treat those roles the same way as how I handle attendance register for non-affiliates. Also, how do I do testing for this????
Thai committedAug 13, 2020 Configuration menu - View commit details
-
Copy full SHA for 8fdbf46 - Browse repository at this point
Copy the full SHA 8fdbf46View commit details
Commits on Aug 14, 2020
-
Completed non-affiliate event sign in use case. Now just need to test.
Thai committedAug 14, 2020 Configuration menu - View commit details
-
Copy full SHA for 56c902b - Browse repository at this point
Copy the full SHA 56c902bView commit details -
Tested POST to /api/events/:eventID/signin and it works fine.
Worked properly for new non-affiliates and recurring non-affiliates in terms of signing up. Modified Attendance entity schema a little (made duration column nullable).
Thai committedAug 14, 2020 Configuration menu - View commit details
-
Copy full SHA for 385f5af - Browse repository at this point
Copy the full SHA 385f5afView commit details
Commits on Aug 15, 2020
-
Made changes based on comments on PR #44 and fixed circular dependency!
Thai committedAug 15, 2020 2Configuration menu - View commit details
-
Copy full SHA for 6d7fb25 - Browse repository at this point
Copy the full SHA 6d7fb25View commit details -
Refactored the code for /api/events/:eventID/signin.
Moved the logic of saving non-affiliate AppUser entities to AppUserService. Changed RegisterAttendance so that it uses AttendanceRepository's Insert instead of Save to prevent inserts of duplicate data.
Thai committedAug 15, 2020 Configuration menu - View commit details
-
Copy full SHA for 20175ec - Browse repository at this point
Copy the full SHA 20175ecView commit details
Commits on Aug 16, 2020
-
Refactor #2 of /api/events/:eventID/signin.
Added RequestToEntityByEmail and AppUserService now doesn't depend on mappers and payloads anymore.
Thai committedAug 16, 2020 Configuration menu - View commit details
-
Copy full SHA for 466f4db - Browse repository at this point
Copy the full SHA 466f4dbView commit details -
Thai committed
Aug 16, 2020 Configuration menu - View commit details
-
Copy full SHA for 399bedc - Browse repository at this point
Copy the full SHA 399bedcView commit details