Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event sign in endpoint (Ready for review) #44

Merged
merged 9 commits into from
Aug 16, 2020
Merged

Commits on Aug 13, 2020

  1. Adding event sign in endpoint (WIP).

    Thai committed Aug 13, 2020
    2 Configuration menu
    Copy the full SHA
    648f7d9 View commit details
    Browse the repository at this point in the history
  2. Changed AppUserEventSignInRequest/Response to EventSignInRequest/Resp…

    …onse.
    
    Also removed agreeToPhotoRelease in EventSignInRequest for now.
    Thai committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    0a41cb9 View commit details
    Browse the repository at this point in the history
  3. Set up everything for registering attendance for signed in user (WIP).

    I still don't know what to do if the AppUser's role is an affiliate role
    (so inductee, member, officer, anything that is not guest). Might just
    treat those roles the same way as how I handle attendance register for
    non-affiliates.
    
    Also, how do I do testing for this????
    Thai committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    8fdbf46 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Configuration menu
    Copy the full SHA
    56c902b View commit details
    Browse the repository at this point in the history
  2. Tested POST to /api/events/:eventID/signin and it works fine.

    Worked properly for new non-affiliates and recurring
    non-affiliates in terms of signing up. Modified Attendance
    entity schema a little (made duration column nullable).
    Thai committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    385f5af View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2020

  1. 2 Configuration menu
    Copy the full SHA
    6d7fb25 View commit details
    Browse the repository at this point in the history
  2. Refactored the code for /api/events/:eventID/signin.

    Moved the logic of saving non-affiliate AppUser entities to
    AppUserService. Changed RegisterAttendance so that it uses
    AttendanceRepository's Insert instead of Save to prevent
    inserts of duplicate data.
    Thai committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    20175ec View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2020

  1. Refactor #2 of /api/events/:eventID/signin.

    Added RequestToEntityByEmail and AppUserService now doesn't depend on
    mappers and payloads anymore.
    Thai committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    466f4db View commit details
    Browse the repository at this point in the history
  2. Refactored some more

    Thai committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    399bedc View commit details
    Browse the repository at this point in the history