Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript #2

Closed
godwinpang opened this issue May 30, 2020 · 0 comments · Fixed by #9
Closed

Typescript #2

godwinpang opened this issue May 30, 2020 · 0 comments · Fixed by #9
Labels
dev experience Focus on enhancing developer experience

Comments

@godwinpang
Copy link
Contributor

We have models in our code that are implemented as JS classes. Since we don't have a lot of code it might just be easier to try out Typescript :))
@godwinpang godwinpang added the dev experience Focus on enhancing developer experience label May 30, 2020
@godwinpang godwinpang mentioned this issue Jun 15, 2020
Merged
thai-truong pushed a commit that referenced this issue Aug 16, 2020
Refactor #2 of /api/events/:eventID/signin.
466f4db 
Added RequestToEntityByEmail and AppUserService now doesn't depend on
mappers and payloads anymore.
godwinpang pushed a commit that referenced this issue Mar 18, 2021
Refactor #2 of /api/events/:eventID/signin.
e9ca196 
Added RequestToEntityByEmail and AppUserService now doesn't depend on
mappers and payloads anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev experience Focus on enhancing developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Massive rehaul to typescript. HKN-UCSD/hkn-server
1 participant
@godwinpang