Implement polls edit and delete.

[gyakkun]

Now the button Edit and Delete in Staff/polls page should work.

Add necessary language items in resources/lang for zh-CN, zh-TW and en.

( Note: As I just begin writing php this week, the code may lack exception handling and so on. Serious review is needed. )

[HDVinnie]

@gyakkun Im going to review this tonight when home. I do think however this whole polls system needs to be re-written from scratch which I plan to do. It was poorly designed and made. Possible refactor might suffice. Ill keep you updated. Thanks again for the contributions and look forward to your translation (i18n) pull requests.

[HDVinnie]

@gyakkun what's your thoughts on removing IPs altogether in this PR. See this issue it would close for ref. #1114

[gyakkun]

@gyakkun what's your thoughts on removing IPs altogether in this PR. See this issue it would close for ref. #1114

I share my opinion of removing ip_check with @HVRVKVT in #1114 . It's better to be done in this PR #1130 .

[gyakkun]

BTW I reckon it as a must for a private tracker to record user's ip, for auditing and cheat check.

The approch we adpot on a running PT in my organization is, adding an independent ip logging table.

Still, the ip logging should be configurable if the staff want the site running public.

[HDVinnie]

BTW I reckon it as a must for a private tracker to record user's ip, for auditing and cheat check.

The approch we adpot on a running PT in my organization is, adding an independent ip logging table.

Still, the ip logging should be configurable if the staff want the site running public.

IP Logging is 99% inefficient. I don't think its worth logging users IP addresses to catch the few that are to stupid or don't care enough to use a VPN...

[gyakkun]

@gyakkun what's your thoughts on removing IPs altogether in this PR. See this issue it would close for ref. #1114

Removed in 957ac57 and 4199867 .

As it's fomerly a configurable option, remove it or not are both acceptable. All up to you and feel free to skip with revert or cherry pick.

[HDVinnie]

@gyakkun what's your thoughts on removing IPs altogether in this PR. See this issue it would close for ref. #1114

Removed in 957ac57 and 4199867 .

As it's fomerly a configurable option, remove it or not are both acceptable. All up to you and feel free to skip with revert or cherry pick.

I feel its best to fully remove the option. You agree?

[gyakkun]

@gyakkun what's your thoughts on removing IPs altogether in this PR. See this issue it would close for ref. #1114

Removed in 957ac57 and 4199867 .
As it's fomerly a configurable option, remove it or not are both acceptable. All up to you and feel free to skip with revert or cherry pick.

I feel its best to fully remove the option. You agree?

Agree.

[gyakkun]

@gyakkun what's your thoughts on removing IPs altogether in this PR. See this issue it would close for ref. #1114

Removed in 957ac57 and 4199867 .
As it's fomerly a configurable option, remove it or not are both acceptable. All up to you and feel free to skip with revert or cherry pick.

I feel its best to fully remove the option. You agree?

What about replace it with "Result is only visible after votes?", it may be more useful.

[HDVinnie]

@gyakkun what's your thoughts on removing IPs altogether in this PR. See this issue it would close for ref. #1114

Removed in 957ac57 and 4199867 .
As it's fomerly a configurable option, remove it or not are both acceptable. All up to you and feel free to skip with revert or cherry pick.

I feel its best to fully remove the option. You agree?

What about replace it with "Result is only visible after votes?", it may be more useful.

I think the poll system can indeed use a lot more. Your idea is good. Others like this on polls table would be neat so you can close a poll at a certain date?:

            $table->boolean('closed')->default(false);
            $table->timestamp('closes_at')->nullable()->default(null);

Also on voters table it might be nice to add option_id so on the poll results page we can highlight what the said user voted for. If you know what I mean.

[gyakkun]

BTW I reckon it as a must for a private tracker to record user's ip, for auditing and cheat check.
The approch we adpot on a running PT in my organization is, adding an independent ip logging table.
Still, the ip logging should be configurable if the staff want the site running public.

IP Logging is 99% inefficient. I don't think its worth logging users IP addresses to catch the few that are to stupid or don't care enough to use a VPN...

I would better explain the necessity in a new open issue #1151. I think it's something more important than efficiency.

[gyakkun]

I think the poll system can indeed use a lot more. Your idea is good. Others like this on polls table would be neat so you can close a poll at a certain date?:

            $table->boolean('closed')->default(false);
            $table->timestamp('closes_at')->nullable()->default(null);

Also on voters table it might be nice to add option_id so on the poll results page we can highlight what the said user voted for. If you know what I mean.

So that can the style add to result page and make the voted option highlight according to the option_id , right? That sounds really nice. It would better be another story in another PR. Hope my PRs on poll feature won't bother your refactor plan, and I will move my hands off from it since I'm not so experienced 😂

Now things have all been done to remove ip_checking, and #1130 can be closed.