Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use user_id for pool checking instead of IPs #1114

Closed
HVRVKVT opened this issue Feb 4, 2020 · 2 comments
Closed

[Enhancement] Use user_id for pool checking instead of IPs #1114

HVRVKVT opened this issue Feb 4, 2020 · 2 comments

Comments

@HVRVKVT
Copy link
Contributor

HVRVKVT commented Feb 4, 2020

Using PIDs instead of ip_checking to prevent voting more than once, is not only preferable, but also a more robust solution. While one could easily change IP, who would want to reset their PID just to vote once more?

@HDVinnie
Copy link
Collaborator

HDVinnie commented Feb 4, 2020

This needs to be removed all together. Instead just check user_id. The poll system needs to be refactored. It is old and was built like this because early UNIT3D supported both usage for a private or public tracker.

@HVRVKVT
Copy link
Contributor Author

HVRVKVT commented Feb 4, 2020

even better 👍

@HVRVKVT HVRVKVT changed the title [Enhancement] Use PIDs for pool checking instead of IPs [Enhancement] Use user_id for pool checking instead of IPs Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants