merge fix branch Bug/tests/result-set-definition-error
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies `words_as_str` to return a comprehensive message upon an invalid or empty string value. Issue: #4 Authored-by: Joshua Rose <[email protected]>
Thanks to gifcord.gg Authored-by: Joshua Rose <[email protected]>
Add alternative installation method for windows and href to windows installation method. Author: Joshua Rose <[email protected]>
Adds additional return types to functions that lack them. Some changes to arguments in docstrings. Omit redundant arguments Authored-by: Joshua Rose <[email protected]>
This commit now shows the author with the definition. Attempted to add function to get likes and dislikes however they are rendered via javascript post-load so that's impossible 👽 Issue: #2 Authored-by: Joshua Rose <[email protected]>
Comments out deprecated function for statistics that would show deprecated text and warning. Issue: #2 Pull Request: #8 Related commit: 7db417f Authored-by: Joshua Rose <[email protected]>
This commit addresses various issues from tests including the deprecated warning not being raised due to the `raise` flag being omitted / not there. In addition to that, theres a few pep/lint changes from my lsp. Issue: #4 Authored-by: Joshua Rose <[email protected]>
- adds tests cases for the word definition class - introduces a working pytest runner. Issue: #4 Authored-by: Joshua Rose <[email protected]>
H4ppy-04
added a commit
that referenced
this pull request
May 24, 2023
* feat: definition string data type assertion This commit modifies `words_as_str` to return a comprehensive message upon an invalid or empty string value. Issue: #4 Authored-by: Joshua Rose <[email protected]> * feat(usage): GIF demonstration of tool Thanks to gifcord.gg Authored-by: Joshua Rose <[email protected]> * feat(gif): add gif demo * feat: add video to readme * feat(docs): refactor documentation Add alternative installation method for windows and href to windows installation method. Author: Joshua Rose <[email protected]> * refactor: additional return types Adds additional return types to functions that lack them. Some changes to arguments in docstrings. Omit redundant arguments Authored-by: Joshua Rose <[email protected]> * feat: show author with definition This commit now shows the author with the definition. Attempted to add function to get likes and dislikes however they are rendered via javascript post-load so that's impossible 👽 Issue: #2 Authored-by: Joshua Rose <[email protected]> * refactor: comment deprecated function Comments out deprecated function for statistics that would show deprecated text and warning. Issue: #2 Pull Request: #8 Related commit: 7db417f Authored-by: Joshua Rose <[email protected]> * feat: lint and fix deprecated warning This commit addresses various issues from tests including the deprecated warning not being raised due to the `raise` flag being omitted / not there. In addition to that, theres a few pep/lint changes from my lsp. Issue: #4 Authored-by: Joshua Rose <[email protected]> * feat: tests for word_definition - adds tests cases for the word definition class - introduces a working pytest runner. Issue: #4 Authored-by: Joshua Rose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks done