Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] test case not implemented with one worded definitions #4

Closed
H4ppy-04 opened this issue May 23, 2023 · 0 comments · Fixed by #9
Closed

[BUG] test case not implemented with one worded definitions #4

H4ppy-04 opened this issue May 23, 2023 · 0 comments · Fixed by #9
Labels
bug Something isn't working

Comments

@H4ppy-04
Copy link
Owner

H4ppy-04 commented May 23, 2023 •
edited
Loading

About
Test case in unit tests file not implemented with one worded definitions.

Description
Occurs when the following is equal to True:

len(ResultSet[Tag].get_text(strip=False).split(" ", -1)) == 0
@H4ppy-04 H4ppy-04 added bug Something isn't working good first issue Good for newcomers labels May 23, 2023
H4ppy-04 added a commit that referenced this issue May 23, 2023
@H4ppy-04
feat: definition string data type assertion
15352c3 
This commit modifies `words_as_str` to return a comprehensive message
upon an invalid or empty string value.

Issue: #4

Authored-by: Joshua Rose <[email protected]>
H4ppy-04 added a commit that referenced this issue May 24, 2023
@H4ppy-04
feat: lint and fix deprecated warning
91f426b 
This commit addresses various issues from tests including the deprecated
warning not being raised due to the `raise` flag being omitted / not
there.

In addition to that, theres a few pep/lint changes from my lsp.

Issue: #4

Authored-by: Joshua Rose <[email protected]>
H4ppy-04 added a commit that referenced this issue May 24, 2023
@H4ppy-04
feat: tests for word_definition
412a17b 
 - adds tests cases for the word definition class
 - introduces a working pytest runner.

Issue: #4

Authored-by: Joshua Rose <[email protected]>
@H4ppy-04 H4ppy-04 linked a pull request May 24, 2023 that will close this issue
merge fix branch Bug/tests/result-set-definition-error #9
Merged
H4ppy-04 added a commit that referenced this issue May 24, 2023
@H4ppy-04
merge fix branch Bug/tests/result-set-definition-error (#9)
a4724e9 
* feat: definition string data type assertion

This commit modifies `words_as_str` to return a comprehensive message
upon an invalid or empty string value.

Issue: #4

Authored-by: Joshua Rose <[email protected]>

* feat(usage): GIF demonstration of tool

Thanks to gifcord.gg

Authored-by: Joshua Rose <[email protected]>

* feat(gif): add gif demo

* feat: add video to readme

* feat(docs): refactor documentation 

Add alternative installation method for windows and href to windows installation method.

Author: Joshua Rose <[email protected]>

* refactor: additional return types

Adds additional return types to functions that lack them.
Some changes to arguments in docstrings.
Omit redundant arguments

Authored-by: Joshua Rose <[email protected]>

* feat: show author with definition

This commit now shows the author with the definition.

Attempted to add function to get likes and dislikes however they are
rendered via javascript post-load so that's impossible 👽

Issue: #2

Authored-by: Joshua Rose <[email protected]>

* refactor: comment deprecated function

Comments out deprecated function for statistics that would show
deprecated text and warning.

Issue: #2
Pull Request: #8
Related commit: 7db417f

Authored-by: Joshua Rose <[email protected]>

* feat: lint and fix deprecated warning

This commit addresses various issues from tests including the deprecated
warning not being raised due to the `raise` flag being omitted / not
there.

In addition to that, theres a few pep/lint changes from my lsp.

Issue: #4

Authored-by: Joshua Rose <[email protected]>

* feat: tests for word_definition

 - adds tests cases for the word definition class
 - introduces a working pytest runner.

Issue: #4

Authored-by: Joshua Rose <[email protected]>
@H4ppy-04 H4ppy-04 added 1.1.1 and removed good first issue Good for newcomers labels May 24, 2023
H4ppy-04 added a commit that referenced this issue May 24, 2023
@H4ppy-04
merge fix branch Bug/tests/result-set-definition-error (#9)
4e435fe 
* feat: definition string data type assertion

This commit modifies `words_as_str` to return a comprehensive message
upon an invalid or empty string value.

Issue: #4

Authored-by: Joshua Rose <[email protected]>

* feat(usage): GIF demonstration of tool

Thanks to gifcord.gg

Authored-by: Joshua Rose <[email protected]>

* feat(gif): add gif demo

* feat: add video to readme

* feat(docs): refactor documentation 

Add alternative installation method for windows and href to windows installation method.

Author: Joshua Rose <[email protected]>

* refactor: additional return types

Adds additional return types to functions that lack them.
Some changes to arguments in docstrings.
Omit redundant arguments

Authored-by: Joshua Rose <[email protected]>

* feat: show author with definition

This commit now shows the author with the definition.

Attempted to add function to get likes and dislikes however they are
rendered via javascript post-load so that's impossible 👽

Issue: #2

Authored-by: Joshua Rose <[email protected]>

* refactor: comment deprecated function

Comments out deprecated function for statistics that would show
deprecated text and warning.

Issue: #2
Pull Request: #8
Related commit: 7db417f

Authored-by: Joshua Rose <[email protected]>

* feat: lint and fix deprecated warning

This commit addresses various issues from tests including the deprecated
warning not being raised due to the `raise` flag being omitted / not
there.

In addition to that, theres a few pep/lint changes from my lsp.

Issue: #4

Authored-by: Joshua Rose <[email protected]>

* feat: tests for word_definition

 - adds tests cases for the word definition class
 - introduces a working pytest runner.

Issue: #4

Authored-by: Joshua Rose <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

merge fix branch Bug/tests/result-set-definition-error H4ppy-04/urban-cli
1 participant
@H4ppy-04