Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly initialize metaTileEntityTank fluid inventory #1311

Closed

Conversation

PrototypeTrousers
Copy link
Contributor

What:
Suggested Fix for #1289 and #1263
Separated from PR #1303
those issues happen due to metaTileEntityTank fluid inventory not being properly initialised on load.

How solved:
calling this.fluidInventory = getActualFluidTank();
instead of initializeInventory();

instead of initializeInventory() is a metaTileEntity method that initialize fluidinventory as
this.fluidInventory = new FluidHandlerProxy(importFluids, exportFluids);
but we have neither importFluids nor exportFluids on meta tile entities tanks, leading
to getTankProperties().length being 0, so when the tank is asked by the cover for its capability, null is returned.
Since the pump need the capability to be non null, it crashes

Outcome:
World loading normally

@LAGIdiot
Copy link
Member

Thank you for your hard work. But this is just partial copy of functionality from #1303 right? As that one have even proper tank forming on load when cover was placed on it.

@LAGIdiot LAGIdiot added subsystem: covers type: bug Something isn't working labels Nov 15, 2020
@PrototypeTrousers
Copy link
Contributor Author

Yes, this fixes ONLY the crash, and as its world breaking i thought this part could go first.
there still multiblock issues even with the other PR.
like client-side desync and fluid voiding.
if you rather wait some more, close this PR and i will merge this one with the tank changes when its ready. Thanks :)

@PrototypeTrousers
Copy link
Contributor Author

closing in favor of #1313

@PrototypeTrousers PrototypeTrousers deleted the FixMetaTankNPE branch May 25, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subsystem: covers type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants