-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Crash with Covers when TileEntities lose their capabilities #1263
Comments
broke between gregtech-1.12.2-1.8.8.440 and gregtech-1.12.2-1.8.9.457 so i guess since multiblock tanks is a thing |
Version: Outcome: Additional information: Implementation notes: |
This comment has been minimized.
This comment has been minimized.
from gregtech/common/covers/CoverPump.java adding the null check avoids the crash but not solves the issue completely, the case being defaultValue should never been null since we check for the capability before even placing the cover. |
Managed to crash a brewery by installing a conveyor, then wrenching its output side to the conveyor. (brewery only has fluid_item_capability on sides other than output, so defaultValue becomes null). crashes after trying to place anything with capability on the same side (conduits,pipe from logistics pipes,etc) |
Closing as this one was already fixed |
* Go over the models quads to see if they can be rendered at a specific layer * optimization * comment
Describe the bug
Placing two Gregtech tanks ( not quantum tanks ) with pumps facing each other in import mode will crash the game on world load.
Versions
Mods:
CodeChickenLib-1.12.2-3.2.3.358-universal
gregtech-1.12.2-1.10.2.566
jei_1.12.2-4.16.1.301
MouseTweaks-2.10-mc1.12.2
Setup
Playing Solo
New world generated
Steps To Reproduce
1)Place 2 tanks adjacent to each other
2)Place pumps on the tanks, facing each other
3)set them to import
4)Save and quit
5)try to load the world
Expected behavior
Placing 2 tanks touching will form a multiblock
Placing one pump will visually show the multiblock not forming anymore.
Placing the second one will work as usual.
Setting the pumps to import
Save and quit
Restart world. Crash.
Crash Report
https://pastebin.com/t2ERFTDJ
Screenshots
tanks placed down
pump installed on right tank
placing water will fill both tanks
saving and reloading will show the multiblock formed again
installed pump in the left tank, set as export
reload world ( if theres still water on both during the save it will crash on load too
setting both pump to import will crash the world on load
The text was updated successfully, but these errors were encountered: