Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 6.0: Escape JSON in Custom HTTP Notifications #20319

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Backport 6.0: Escape JSON in Custom HTTP Notifications #20319

merged 1 commit into from
Sep 3, 2024

Conversation

kingzacko1
Copy link
Contributor

backport #20318 to 6.0

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@kingzacko1
Escape double quotes in all strings, not just top level model strings (…
bd99287 
…#20318)

* Escape double quotes in all strings, not just top level model strings
@kingzacko1 kingzacko1 changed the base branch from master to 6.0 August 31, 2024 01:19
ryan-carroll-graylog
ryan-carroll-graylog approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests successfully on 6.0

@kingzacko1 kingzacko1 merged commit b3c68c1 into 6.0 Sep 3, 2024
4 checks passed
@kingzacko1 kingzacko1 deleted the backport-6.0/escape-json-in-customhttpnotifications branch September 3, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-carroll-graylog ryan-carroll-graylog ryan-carroll-graylog approved these changes

@danotorrey danotorrey Awaiting requested review from danotorrey

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingzacko1 @ryan-carroll-graylog